Repository navigation
Sync typespec-java core and drop liftr-base/openai peer & dev deps #4916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Xiaofei Cao (XiaofeiCao)
merged 8 commits into
Azure:release/july-2026
from
XiaofeiCao:xiaofeicao/typespec-java-core-sync-remove-deps
Jul 20, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cd7ad2a
Sync typespec-java core to PR 11286 and drop liftr-base/openai peer &…
XiaofeiCao 877fa40
Regenerate pnpm-lock.yaml after removing liftr-base/openai deps
XiaofeiCao 80df5d8
Add changelog for removing liftr-base/openai deps
XiaofeiCao 061d658
Add changelog for per-client ServiceVersion regression fix (core PR 1…
XiaofeiCao 0d320b3
Simplify per-client ServiceVersion changelog message
XiaofeiCao 3e59173
Sync core-commit.json to latest core main (8cef6d9)
XiaofeiCao 907726d
Add changelog for clientApiVersions support (core PR 11290)
XiaofeiCao 27cb879
Sync emitter-tests version to typespec-java emitter version in SyncTe…
XiaofeiCao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
.chronus/changes/typespec-java-fix-per-client-serviceversion-2026-07-17-14-32-0.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| changeKind: fix | ||
| packages: | ||
| - "@azure-tools/typespec-java" | ||
| --- | ||
|
|
||
| Fix per-client `ServiceVersion` regression after migrating from js-yaml and lodash. |
7 changes: 7 additions & 0 deletions
7
.chronus/changes/typespec-java-remove-liftr-openai-deps-2026-07-17-14-29-0.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| changeKind: dependencies | ||
| packages: | ||
| - "@azure-tools/typespec-java" | ||
| --- | ||
|
|
||
| Remove `@azure-tools/typespec-liftr-base` and `@azure-tools/openai-typespec` from the peer and dev dependencies. |
7 changes: 7 additions & 0 deletions
7
.chronus/changes/typespec-java-support-client-api-versions-2026-07-17-17-22-0.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| changeKind: feature | ||
| packages: | ||
| - "@azure-tools/typespec-java" | ||
| --- | ||
|
|
||
| Support `clientApiVersions`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| { "sha": "42927da57e230b59a93e3a36d787c4ede5e50051" } | ||
| { "sha": "8cef6d928a2ac3237d5eacb69b4ac671a54bcf92" } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
packages/typespec-java/emitter-tests/tsp/multiple-clients-same-version.tsp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| import "@typespec/rest"; | ||
| import "@typespec/http"; | ||
| import "@typespec/versioning"; | ||
| import "@azure-tools/typespec-client-generator-core"; | ||
|
|
||
| using TypeSpec.Http; | ||
| using TypeSpec.Versioning; | ||
| using Azure.ClientGenerator.Core; | ||
|
|
||
| // A single versioned service that is split into two clients (AlphaClient, BetaClient). Both | ||
| // clients therefore share the same set of api-versions. In this case the emitter must generate a | ||
| // SINGLE shared `MultipleClientsSameVersionServiceVersion` enum (named after the service), NOT a | ||
| // separate `<ClientName>ServiceVersion` per client. | ||
| // | ||
| // Regression test for the api-version comparison in code-model-builder.ts (getServiceVersion | ||
| // postprocess): comparing ApiVersion object references (with `===`) instead of the version | ||
| // strings incorrectly produced one ServiceVersion enum per client here, because each client | ||
| // builds its own ApiVersion instances. | ||
| @service(#{ title: "MultipleClientsSameVersion" }) | ||
| @versioned(ServiceApiVersions) | ||
| namespace TspTest.MultipleClientsSameVersion; | ||
|
|
||
| enum ServiceApiVersions { | ||
| v2023_01_01: "2023-01-01", | ||
| v2023_06_01: "2023-06-01", | ||
| } | ||
|
|
||
| model Resource { | ||
| @visibility(Lifecycle.Read) | ||
| id: string; | ||
|
|
||
| name: string; | ||
| } | ||
|
|
||
| @client({ | ||
| service: TspTest.MultipleClientsSameVersion, | ||
| name: "AlphaClient", | ||
| }) | ||
| @route("/alpha") | ||
| interface AlphaClient { | ||
| @get | ||
| getAlpha(@path id: string): Resource; | ||
| } | ||
|
|
||
| @client({ | ||
| service: TspTest.MultipleClientsSameVersion, | ||
| name: "BetaClient", | ||
| }) | ||
| @route("/beta") | ||
| interface BetaClient { | ||
| @get | ||
| getBeta(@path id: string): Resource; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.