Skip to content

[python] update pylintrc to disable no-cross-package-private-import - #4970

Merged
Yuchao Yan (msyyc) merged 3 commits into
mainfrom
updatepylintrc
Jul 21, 2026
Merged

[python] update pylintrc to disable no-cross-package-private-import#4970
Yuchao Yan (msyyc) merged 3 commits into
mainfrom
updatepylintrc

Conversation

@JennyPng

@JennyPng jenny (JennyPng) commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

disable no-cross-package-private-import for false positives, mirrors pylintrc in typespec repo to resolve errors seen here https://github.com/microsoft/typespec/actions/runs/29559758738/job/87821055874?pr=11289 for microsoft/typespec#11289

e.g.

ERROR:root:/home/runner/work/typespec/typespec/packages/typespec-python/tests/generated/azure/azure-client-generator-core-usage/specs exited with linting error 16
************* Module client.naming.typeddict.aio.operations._operations
generated/azure/client-naming-typeddict/client/naming/typeddict/aio/operations/_operations.py:32: [C4776(no-cross-package-private-import), ] Do not import private APIs from other packages. Private modules (prefixed with '_') are internal implementation details and may change without notice. Use the public API instead.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the emitter:python Issues for @azure-tools/typespec-python emitter label Jul 20, 2026
@azure-sdk-automation

azure-sdk-automation Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

All changed packages have been documented.

  • ✅ @azure-tools/typespec-python
Show changes

@azure-tools/typespec-python - internal ✏️

Disable no-cross-package-private-import pylint check

@pkg-pr-new

pkg-pr-new Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@azure-tools/typespec-python@4970

commit: c28c843

@JennyPng
jenny (JennyPng) marked this pull request as ready for review July 20, 2026 18:17
@azure-sdk-automation

azure-sdk-automation Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

You can try these changes here

🛝 Playground 🌐 Website

@msyyc
Yuchao Yan (msyyc) added this pull request to the merge queue Jul 21, 2026
@msyyc
Yuchao Yan (msyyc) removed this pull request from the merge queue due to a manual request Jul 21, 2026
@msyyc
Yuchao Yan (msyyc) added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit b6469c3 Jul 21, 2026
31 of 32 checks passed
@msyyc
Yuchao Yan (msyyc) deleted the updatepylintrc branch July 21, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msyyc Yuchao Yan (msyyc) msyyc approved these changes
@iscai-msft iscai-msft Awaiting requested review from iscai-msft iscai-msft is a code owner
@tadelesh Chenjie Shi (tadelesh) Awaiting requested review from tadelesh tadelesh is a code owner
@l0lawrence Libba Lawrence (l0lawrence) Awaiting requested review from l0lawrence l0lawrence is a code owner
@ChenxiJiang333 Chenxi Jiang (ChenxiJiang333) Awaiting requested review from ChenxiJiang333 ChenxiJiang333 is a code owner
@kashifkhan Kashif Khan (kashifkhan) Awaiting requested review from kashifkhan kashifkhan is a code owner
@bterlson Brian Terlson (bterlson) Awaiting requested review from bterlson
@markcowl Mark Cowlishaw (markcowl) Awaiting requested review from markcowl markcowl is a code owner
@timotheeguerin Timothee Guerin (timotheeguerin) Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees

No one assigned

Labels

emitter:python Issues for @azure-tools/typespec-python emitter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JennyPng @msyyc