Skip to content

fix(typespec-python): remove shell:true from spawn to eliminate DEP0190 deprecation warning #5001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

fix(typespec-python): remove shell:true from spawn to eliminate DEP0190 deprecation warning #5001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
621a086
Initial plan
Copilot Jul 21, 2026
9ccee3f
fix: remove shell:true from spawn in system-requirements.ts to fix DE…
Copilot Jul 21, 2026
6be0f3c
fix: use cross-spawn instead of child_process.spawn in system-require…
l0lawrence Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/fix-deprecated-node-api-2026-7-24-15-2-0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: internal
packages:
- "@azure-tools/typespec-python"
---

Use `cross-spawn` instead of `child_process.spawn` in the system requirements setup script. This removes the DEP0190 deprecation warning caused by `shell: true` while keeping support for executing `.cmd`/`.bat` wrappers (e.g. `python.cmd`) on Windows.
15 changes: 8 additions & 7 deletions packages/typespec-python/eng/scripts/setup/system-requirements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { ChildProcess, spawn, SpawnOptions } from "child_process";
import type { ChildProcess, SpawnOptions } from "child_process";
import { spawn } from "cross-spawn";
import { coerce, satisfies } from "semver";

/*
Expand All @@ -11,26 +12,26 @@ const execute = (
options: MoreOptions = {},
): Promise<ExecResult> => {
return new Promise((resolve, reject) => {
const cp = spawn(command, cmdlineargs, { ...options, stdio: "pipe", shell: true });
const cp = spawn(command, cmdlineargs, { ...options, stdio: "pipe" });

@timotheeguerin Timothee Guerin (timotheeguerin) Jul 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is command going to be, is that cross platform compatible?

@l0lawrence Libba Lawrence (l0lawrence) Jul 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be py,python3, or python

@timotheeguerin Timothee Guerin (timotheeguerin) Jul 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But isn't it python.cmd on windows. I think this is the reason shell was set to true so it works on windows. It is good to remove shell: true but I think need to use crossspawn package instead or need to be smarter about finding the command

@l0lawrence Libba Lawrence (l0lawrence) Jul 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was .exe but let me look

@timotheeguerin Timothee Guerin (timotheeguerin) Jul 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok just wanted to make sure it does actually work across platforms, windows is super annoying with what you can call with spawn. If it does then this looks good

if (options.onCreate) {
options.onCreate(cp);
}

if (options.onStdOutData) {
cp.stdout.on("data", options.onStdOutData);
cp.stdout?.on("data", options.onStdOutData);
}
if (options.onStdErrData) {
cp.stderr.on("data", options.onStdErrData);
cp.stderr?.on("data", options.onStdErrData);
}

let err = "";
let out = "";
let all = "";
cp.stderr.on("data", (chunk) => {
cp.stderr?.on("data", (chunk) => {
err += chunk;
all += chunk;
});
cp.stdout.on("data", (chunk) => {
cp.stdout?.on("data", (chunk) => {
out += chunk;
all += chunk;
});
Expand Down Expand Up @@ -111,7 +112,7 @@ const tryPython = async (
const result = await execute(command, [
...additionalArgs,
"-c",
`"${PRINT_PYTHON_VERSION_SCRIPT}"`,
PRINT_PYTHON_VERSION_SCRIPT,
]);
return validateVersionRequirement(resolution, result.stdout.trim(), requirement);
} catch (e) {
Expand Down
2 changes: 2 additions & 0 deletions packages/typespec-python/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
},
"dependencies": {
"@typespec/http-client-python": "catalog:",
"cross-spawn": "catalog:",
"semver": "catalog:",
"tsx": "catalog:"
},
Expand All @@ -76,6 +77,7 @@
"@azure-tools/typespec-azure-resource-manager": "workspace:^",
"@azure-tools/typespec-azure-rulesets": "workspace:^",
"@azure-tools/typespec-client-generator-core": "workspace:^",
"@types/cross-spawn": "catalog:",
"@types/node": "catalog:",
"@types/semver": "catalog:",
"@types/yargs": "catalog:",
Expand Down
6 changes: 6 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.