Repository navigation
[Swagger Linter Migration] DescriptionMustNotBeNodeName + DescriptiveDescriptionRequired -> documentation-required #5663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Yuchao Yan (msyyc)
wants to merge
23
commits into
main
Choose a base branch
from
promote-lintdiff-description-must-not-be-node-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+507
−160
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d7b4a89
Promote documentation quality lint rule to Azure Core
msyyc 9bdd488
Fix inferred HTTP verbs and JSON names in documentation lint promotion
msyyc 2c5214b
Refresh no-uninformative-doc from reviewed multipart source
msyyc 0a9455b
Promote DescriptiveDescriptionRequired as Core no-empty-doc
msyyc 603330a
refactor(core): combine documentation checks without policy expansion
msyyc b6834e1
test(core): replace documentation parsing with semantic fixtures
msyyc 2068349
fix(core): reject blank docs in documentation-required
msyyc 5e8dc59
fix(core): consolidate descriptive docs into documentation-required
msyyc 208e3e6
docs: clarify consolidated lintdiff rule coverage
msyyc 7cd29bd
docs: clarify consolidated lintdiff rule coverage
msyyc 8a3c53e
docs: separate consolidated documentation coverage sections
msyyc 105eb1b
fix(samples): satisfy strengthened documentation rule
msyyc e4e52da
fix(core): combine documentation quality migrations
msyyc 4153348
Avoid unnecessary HTTP resolution in documentation validation
msyyc 4868be2
Merge branch 'main' into promote-lintdiff-description-must-not-be-nod…
msyyc 57eb47e
test(core): consolidate documentation quality coverage
msyyc 176a5f1
Merge main and preserve rule inventory assertions for #5663
msyyc 85ac77b
refactor(azure-core): simplify documentation rule validation
msyyc 3612bc1
Merge remote-tracking branch 'origin/main' into promote-lintdiff-desc…
Copilot b5ade3c
test(azure-core): remove duplicate documentation-rule case
msyyc b3b1a18
fix(azure-core): simplify documentation rule after review
msyyc 1c85b08
Merge branch 'main' into promote-lintdiff-description-must-not-be-nod…
msyyc e00571b
Inline documentation-required diagnostic messages
msyyc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| --- | ||
| changeKind: feature | ||
| packages: | ||
| - "@azure-tools/typespec-azure-core" | ||
| --- | ||
|
|
||
| Strengthen `documentation-required` to reject explicitly empty or whitespace-only documentation and descriptions that repeat a declaration's name or the placeholder `description`. Ordinary properties use their authored names, regardless of JSON serialization names; HTTP parameters and multipart parts retain their HTTP names. Explicit-documentation checks also cover namespaces, interfaces, scalars, inline properties, union variants, and declarations exempt from missing-doc requirements when their documentation is exposed by the compiler. Operation descriptions are compared with both the source operation name and effective HTTP verb. Missing-documentation requirements and exemptions are unchanged. The existing data-plane and resource-manager rulesets already enable this rule. | ||
|
|
||
| ```tsp | ||
| // Warns: the description only repeats the authored name. | ||
| /** Widget */ | ||
| model Widget {} | ||
| ``` |
7 changes: 7 additions & 0 deletions
7
...hanges/promote-lintdiff-description-must-not-be-node-name-2026-9-14-18-55-26.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| changeKind: internal | ||
| packages: | ||
| - "@azure-tools/typespec-samples" | ||
| --- | ||
|
|
||
| Update Widget Manager color and ARM library provisioning-state descriptions to satisfy documentation-required, and regenerate sample snapshots. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.