Skip to content

docs(skills): prioritize native lint simplification in review - #5746

Merged
Yuchao Yan (msyyc) merged 1 commit into
feature/lintdiff-migration-newfrom
skills/native-lint-simplification
Oct 16, 2026
Merged

Yuchao Yan (msyyc) merged 1 commit into
feature/lintdiff-migration-newfrom
skills/native-lint-simplification

Conversation

@msyyc

Copy link
Copy Markdown
Member

Summary

  • Treat a lint brief/PR description as the proposal under review, not a reason to reject clear requests to simplify, revert, or consolidate it.
  • Compare existing native mechanisms first; distinguish native requirements and released compatibility from legacy parity and complexity introduced by the proposal.
  • Delete framework-only suppression/enablement tests without replacement while retaining concrete rule-owned interactions, authored-node deduplication, and meaningful regression preconditions.
  • Remove bespoke per-rule Markdown parsers instead of moving them into another suite. Validate published snippets through existing shared tooling or recorded one-time execution, without claiming continuous coverage from a one-time receipt.
  • Keep actual policy/authorization gates, source immutability, required validation, and released compatibility intact. Track replies separately from satisfaction of review concerns.

Evidence and rationale

This skill-only change follows a retrospective of recorded migration feedback, not a new live-head review or a change to the underlying rule PRs.

The validation skill already discouraged framework-only unit tests, but evidence-preservation wording could encourage relocating them. Promotion still explicitly accommodated per-rule Markdown extraction. These instructions now agree on removing unnecessary infrastructure without discarding rule-owned behavior or honest published-example evidence.

Scope

Only five existing skill Markdown files change: discovery, implementation, validation, development, and promotion. No production rules, package tests, dependencies, submodules, generated artifacts, release entries, or CI configuration change. Two custom review/fix skills stored outside this repository were updated locally in the same task; they are not included in this PR.

Base: feature/lintdiff-migration-new, as explicitly requested.

Validation

  • Existing Prettier 3.9.5: focused Markdown format/check for the changed files.
  • git diff --check.
  • Checked 78 concrete local Markdown references and heading anchors across the five changed repository skills; template URL placeholders were excluded.
  • Reviewed the complete task diff and reconciled development/promotion references with the shared validation guidance.

The root Prettier configuration could not load the unbuilt core TypeSpec plugin. Formatting therefore used the existing Prettier Markdown parser with the root style options and no custom plugins; no dependency installation, submodule initialization, or build was performed for this documentation-only change. Package/source lint and test suites are not applicable under the skill-only lightweight-validation policy. Normal CI is left enabled.

Separate review direction from policy gates, remove framework-only test infrastructure, and distinguish one-time example evidence from continuous coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@msyyc
Yuchao Yan (msyyc) merged commit b6b6565 into feature/lintdiff-migration-new Oct 16, 2026
3 checks passed
@msyyc
Yuchao Yan (msyyc) deleted the skills/native-lint-simplification branch October 16, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant