Skip to content

Update ARM samples to common-types v6 - #5783

Closed
Yuchao Yan (msyyc) wants to merge 1 commit into
Azure:mainfrom
msyyc:prepare-arm-samples-common-types-v6
Closed

Yuchao Yan (msyyc) wants to merge 1 commit into
Azure:mainfrom
msyyc:prepare-arm-samples-common-types-v6

Conversation

@msyyc

Copy link
Copy Markdown
Member

Summary

Extract the ARM sample/common-types updates requested in the review of #5271 into a separate prerequisite PR. This PR changes no production linter policy, registration or enablement.

  • Update current ARM samples to common-types v6 and carry their corresponding emitted OpenAPI snapshots together.
  • Add the seven v6 JSON fixtures required by the samples' local references. They are byte-identical to packages/samples/common-types/existing/v6, whose provenance is Azure/azure-rest-api-specs.
  • Extend the existing common-types synchronization script to write v6 downloads to both the canonical baseline and the ARM sample fixture location. Existing v3-v5 sample fixtures are not changed.
  • Check fixture byte equality and recursively validate local OpenAPI references, including JSON pointer targets.

Legacy and version-compatibility samples retain their existing versions. Suppressions needed specifically by #5271's proposed latest-version warning remain in that rule PR, not here. Once this prerequisite lands, #5271 can incorporate main and drop the duplicated sample delta; no merge is performed by this workflow.

Local validation

  • Sample dependency-closure build passed at Azure main 87ce9388e2d576218666a319997eec201f975fea, compiler 50240c7db77895b261ab2a511f7f79e5650db59b.
  • mise exec -- pnpm exec vitest run --config vitest.config.fast.ts --project azure-samples packages/samples/test/samples.test.ts packages/samples/test/references.test.ts --testNamePattern 'Azure Resource Manager|resolves local references|keeps ARM sample v6' --pool=threads --maxWorkers=1 --reporter=dot: 34 passed, 8 unrelated data-plane cases excluded by the selector.
  • Controlled execution of the actual synchronization script passed: all four canonical versions written, v6 written identically to both locations, older sample locations untouched; no network calls.
  • mise exec -- pnpm check:eng, root pnpm format, root pnpm lint, and git diff --check passed.
  • Chronus reports No package changed for the private samples package; no public-package release note is introduced.

Fresh worktree setup required frozen dependency restoration. Initial attempts exposed missing Vitest, core formatting/build tools, Vite types used by mandatory root lint, and the unbuilt engineering bundle-uploader. Restoring/building those existing pinned dependencies allowed the commands above to pass; no dependency manifests, lockfile, compiler pointer, timeout limits or verification checks were changed.

These are local results, not a claim of completed CI.

Synchronize the v6 sample fixtures with their canonical source and validate local snapshot references.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

No changes needing a change description found.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Package size report

✅ No notable package size changes compared to the base branch.

14 package(s) with no notable change
Package Packed (base → head) Δ Packed Unpacked (base → head) Δ Unpacked
@azure-tools/azure-http-specs 143.53 KB → 143.53 KB — 1.20 MB → 1.20 MB —
@azure-tools/typespec-autorest 87.87 KB → 87.87 KB — 424.17 KB → 424.17 KB —
@azure-tools/typespec-autorest-canonical 7.42 KB → 7.42 KB — 26.00 KB → 26.00 KB —
@azure-tools/typespec-azure-core 136.55 KB → 136.55 KB — 733.30 KB → 733.30 KB —
@azure-tools/typespec-azure-examples 80.15 KB → 80.15 KB — 383.36 KB → 383.36 KB —
@azure-tools/typespec-azure-portal-core 36.26 KB → 36.26 KB — 242.62 KB → 242.62 KB —
@azure-tools/typespec-azure-resource-manager 189.87 KB → 189.87 KB — 1.14 MB → 1.14 MB —
@azure-tools/typespec-azure-rulesets 5.95 KB → 5.95 KB — 34.79 KB → 34.79 KB —
@azure-tools/typespec-client-generator-core 248.86 KB → 248.86 KB — 1.32 MB → 1.32 MB —
@azure-tools/typespec-go 264.28 KB → 264.28 KB — 1.35 MB → 1.35 MB —
@azure-tools/typespec-java 20.22 MB → 20.22 MB — 22.51 MB → 22.51 MB —
@azure-tools/typespec-metadata 15.91 KB → 15.91 KB — 62.26 KB → 62.26 KB —
@azure-tools/typespec-python 42.58 KB → 42.58 KB — 166.02 KB → 166.02 KB —
@azure-tools/typespec-ts 530.76 KB → 530.76 KB — 2.67 MB → 2.67 MB —

Packed = gzipped .tgz published to npm. Unpacked = total extracted size. 🆕 added, 🗑️ removed. Packages from the core/ submodule are not included.
🔴 grew · 🟢 shrank — only changes of at least 512 B and 0.5% are marked.

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

You can try these changes here

🛝 Playground 🌐 Website

@msyyc
Yuchao Yan (msyyc) deleted the prepare-arm-samples-common-types-v6 branch October 21, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant