Repository navigation
Update ARM samples to common-types v6 - #5783
Closed
Yuchao Yan (msyyc) wants to merge 1 commit into
Closed
Yuchao Yan (msyyc) wants to merge 1 commit into
Yuchao Yan (msyyc) wants to merge 1 commit into
Conversation
Synchronize the v6 sample fixtures with their canonical source and validate local snapshot references. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Yuchao Yan (msyyc)
requested review from
Mark Cowlishaw (markcowl),
Timothee Guerin (timotheeguerin) and
Jeff Fisher (xirzec)
as code owners
October 21, 2026 04:08
Contributor
|
No changes needing a change description found. |
Contributor
📦 Package size report✅ No notable package size changes compared to the base branch. 14 package(s) with no notable change
Packed = gzipped |
Contributor
|
You can try these changes here
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the ARM sample/common-types updates requested in the review of #5271 into a separate prerequisite PR. This PR changes no production linter policy, registration or enablement.
packages/samples/common-types/existing/v6, whose provenance is Azure/azure-rest-api-specs.Legacy and version-compatibility samples retain their existing versions. Suppressions needed specifically by #5271's proposed latest-version warning remain in that rule PR, not here. Once this prerequisite lands, #5271 can incorporate main and drop the duplicated sample delta; no merge is performed by this workflow.
Local validation
87ce9388e2d576218666a319997eec201f975fea, compiler50240c7db77895b261ab2a511f7f79e5650db59b.mise exec -- pnpm exec vitest run --config vitest.config.fast.ts --project azure-samples packages/samples/test/samples.test.ts packages/samples/test/references.test.ts --testNamePattern 'Azure Resource Manager|resolves local references|keeps ARM sample v6' --pool=threads --maxWorkers=1 --reporter=dot: 34 passed, 8 unrelated data-plane cases excluded by the selector.mise exec -- pnpm check:eng, rootpnpm format, rootpnpm lint, andgit diff --checkpassed.No package changedfor the private samples package; no public-package release note is introduced.Fresh worktree setup required frozen dependency restoration. Initial attempts exposed missing Vitest, core formatting/build tools, Vite types used by mandatory root lint, and the unbuilt engineering bundle-uploader. Restoring/building those existing pinned dependencies allowed the commands above to pass; no dependency manifests, lockfile, compiler pointer, timeout limits or verification checks were changed.
These are local results, not a claim of completed CI.