Repository navigation
Update ARM samples to common-types v6 - #5787
Open
Yuchao Yan (msyyc) wants to merge 2 commits into
Open
Yuchao Yan (msyyc) wants to merge 2 commits into
Yuchao Yan (msyyc) wants to merge 2 commits into
Conversation
Synchronize the v6 sample fixtures with their canonical source and validate local snapshot references. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Yuchao Yan (msyyc)
requested review from
Mark Cowlishaw (markcowl),
Timothee Guerin (timotheeguerin) and
Jeff Fisher (xirzec)
as code owners
October 21, 2026 07:19
Contributor
|
No changes needing a change description found. |
Contributor
📦 Package size report1 package changed size, +21.03 KB (+0.1%) packed overall.
13 package(s) with no notable change
Packed = gzipped |
Contributor
|
You can try these changes here
|
Write all supported common-types versions to both fixture locations, fill missing v3/v4 fixtures, and remove the redundant reference test file. Retain recursive reference validation as recorded one-time acceptance evidence. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Timothee Guerin (timotheeguerin)
approved these changes
Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the ARM sample/common-types updates requested in the review of #5271 into a separate prerequisite PR. This PR changes no production linter policy, registration or enablement.
packages/samples/common-types/existing/v6, whose provenance is Azure/azure-rest-api-specs.references.test.tsfile. The existing synchronization CI job checks fixture freshness; recursive local-reference and JSON-pointer validation was executed as a one-time acceptance check, not retained as continuous test coverage.Legacy and version-compatibility samples retain their existing versions. Suppressions needed specifically by #5271's proposed latest-version warning remain in that rule PR, not here. Once this prerequisite lands, #5271 can incorporate main and drop the duplicated sample delta; no merge is performed by this workflow.
Local validation after review
Validated in an isolated worktree based on
b12756724b5efd54875f0ecbc0cb3892e913c53f, with the unchanged compiler pin50240c7db77895b261ab2a511f7f79e5650db59b.mise exec -- pnpm -r --filter '@azure-tools/typespec-samples...' build: passed.mise exec -- pnpm exec vitest run --config vitest.config.fast.ts --project azure-samples packages/samples/test/samples.test.ts --testNamePattern 'Azure Resource Manager' --pool=threads --maxWorkers=1 --reporter=dot: 32 passed, 8 unrelated data-plane cases excluded by the selector. The canonical snapshot suite checks compilation diagnostics as well as emitted output.eng/scripts/sync-common-types.ts, with downloads supplied from the pinned canonical fixtures and unexpected network requests rejected: all four versions written to both destinations; all 22 fixture pairs byte-identical, including the four previously absent v3/v4 sample files.mise exec -- pnpm check:eng, rootmise exec -- pnpm format, rootmise exec -- pnpm lint, andgit diff --check: passed.mise exec -- pnpm exec chronus verify --since b12756724b5efd54875f0ecbc0cb3892e913c53f: passed; no public-package release note is needed for these engineering/private-sample changes.Fresh-worktree dependency restoration populated the required Node tooling but its unrelated Python-emitter prepare hook failed with a TLS handshake failure downloading Python package metadata. The sample dependency closure and the existing engineering bundle-uploader dependency were built separately; all validation commands listed above passed. No dependency manifests, lockfile, compiler pointer, timeout limits or verification checks were changed.
These are local validation results, not a claim that CI on the review-fix commit has passed.