Repository navigation
Fix token cache debug log redaction - #970
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3a2461b7-7e6f-4fb8-a822-db855b140539
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Client assertions and broker account identifiers can still leak through debug logs.
2 open findings
What changed in this PR
Redacts authentication secrets and usernames from token-cache debug logs while preserving cached data.
Changes:
- Expands debug-log redaction.
- Adds regression tests for redaction and cache integrity.
| File | Description |
|---|---|
msal/token_cache.py |
Extends event-field masking. |
tests/test_token_cache.py |
Tests redaction without data mutation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3a2461b7-7e6f-4fb8-a822-db855b140539
Avery-Dunn
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redact sensitive authentication fields and usernames from token cache debug logs without changing cached data. Add regression tests.