Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do you think? Valuable?
This feature allows optional per desktop layouts, so you can have different layouts per desktop and display.
If not set, it falls back to the default layout of the particular display or the built in default.
Summary
enablePerDesktopLayoutssetting (default off, backward-compatible):once enabled, each virtual desktop gets its own independent layout,
cloned from the display's shared layout the first time that desktop is
edited — it diverges from then on instead of aliasing the same shared
object as other not-yet-customised desktops.
mouse at the left/right screen edge to reveal an arrow that switches to
the adjacent desktop, or use your own workspace hotkey — either way the
editor immediately reflects the newly active desktop's layout. Closing
the editor restores whichever desktop was active when it was opened.
Fixes found while building this
extension.js:uuidwas hardcoded instead of read from themetaargument Cinnamon passes to
init(). Now reads it correctly, which alsomakes running a differently-named fork side by side with the original a
non-issue (separate config directories).
grid-editor.js: the load/save preset dialogs are separate top-levelactors drawn on top of the main canvas, but motion/button/key events
still reached the editor operations underneath while a dialog was open
(e.g. silently starting a split preview behind the dialog). Now guarded.
grid-editor.js: preset preview tiles applied their inset margin twice(once in
calculateRects, again in thedrawLayoutcall), whichcancelled out and left the grid preview flush against the tile edge
instead of centered. Fixed.