Modernize GitHub Actions CI workflows - #515
Merged
Merged
Conversation
Consolidate quality checks, bump actions, pin Flutter, and add concurrency, permissions, and timeouts. Co-authored-by: Cursor <cursoragent@cursor.com>
Merge format/analyze/tests into a quality job, run unit tests again, and align hygiene with the main workflow. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep workflow action versions current with weekly grouped PRs. Co-authored-by: Cursor <cursoragent@cursor.com>
flutter-action rejects flutter-version: stable; use an explicit SDK version instead. Co-authored-by: Cursor <cursoragent@cursor.com>
AGP 9 with Flutter's builtInKotlin=false opt-out breaks transitive jni 1.0.1, which CI resolves without a lockfile. Co-authored-by: Cursor <cursoragent@cursor.com>
Empty test mains exit with code 79 under flutter test, which failed the Firebase quality job. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Pull request overview
This PR modernizes the repository’s CI setup (GitHub Actions + Dependabot) and updates the Android example tooling to stay compatible with current Flutter/Gradle/Kotlin constraints, while also re-enabling Firebase package unit tests so CI test runs are meaningful.
Changes:
- Updates GitHub Actions workflows (newer actions, combined “quality” job, pinned Flutter version, permissions/concurrency/timeouts, narrower path filters).
- Re-enables Firebase unit tests and adds a small smoke test to avoid “No tests were found”.
- Adjusts the Android example project tooling versions (AGP/Gradle/Kotlin) for compatibility.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| flutter_cache_manager/example/android/settings.gradle | Pins AGP/Kotlin plugin versions and documents staying on AGP 8.x. |
| flutter_cache_manager/example/android/gradle/wrapper/gradle-wrapper.properties | Downgrades Gradle wrapper to 8.14 for compatibility with AGP 8.x. |
| flutter_cache_manager/example/android/gradle.properties | Updates comments around Flutter migrator compatibility flags. |
| flutter_cache_manager/example/android/app/build.gradle | Updates plugin application order and Kotlin configuration (but see review comment about Kotlin plugin id). |
| flutter_cache_manager/CHANGELOG.md | Adds Unreleased notes for CI + Android example tooling updates. |
| flutter_cache_manager_firebase/test/flutter_cache_manager_firebase_test.dart | Adds a basic test so CI flutter test runs actual tests. |
| flutter_cache_manager_firebase/CHANGELOG.md | Adds Unreleased notes for CI modernization + test addition. |
| .github/workflows/build.yaml | Modernizes main package workflow (combined quality job, pinned Flutter, updated actions, timeouts/concurrency/permissions). |
| .github/workflows/build-firebase.yaml | Modernizes Firebase workflow similarly and re-enables tests. |
| .github/dependabot.yml | Adds monthly Dependabot updates for GitHub Actions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mvanbeusekom
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
CI / tooling update for the GitHub Actions workflows and Dependabot.
checkout@v4,setup-java@v4)flutter configenable flags andarchitecture: x64are still set.github/workflows/**, so editing one workflow triggers the other🆕 What is the new behavior (if this is a feature change)?
actions/checkoutto@v5andactions/setup-javato@v5qualityjob with shared Flutter setupdart-lang/setup-dartonlyarchitecture: x643.44.4, add permissions/concurrency/timeoutsgithub-actionsupdates💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
buildworkflow passes on this PR forflutter_cache_managerpathsbuild firebaseworkflow passes when Firebase paths change📝 Links to relevant issues/docs
N/A — follow-up to CI hygiene recommendations for
.github/workflows/build.yamlandbuild-firebase.yaml.🤔 Checklist before submitting