Repository navigation
SEO, Adresse für Basare, einfachere Registrierung, Basar anlegen ohne Konto - #234
Merged
Merged
Conversation
- Unknown paths answer 404 with noindex instead of the start page (soft 404); src/shared/appRoutes.ts lists the app's routes, a test keeps it in sync - Pages behind the sign-in load as own chunks: main bundle 721 -> 470 kB gzip; signed-in users preload them, a chunk of an old deploy reloads once - Event JSON-LD in one shared builder: structured address from a German postal code in the location, preview image as fallback - PNG logo for the Organization data, unused hero image removed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Street, postal code and town next to the location, which becomes the venue's name (migration 0015); optional, an edit without `address` keeps it, so older apps do not erase it - Older events get the fields filled from their location when edited - Pages, titles and JSON-LD use the address: "Kinderbasar in Ulm", a PostalAddress for Google's event search; search matches it too Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- One OAuthButtons component at the top of both pages: one click signs in or creates the account and returns to where the user wanted to go - Register asks for email and one password (10+ characters, show/hide) instead of a confirmation field and five composition rules - The terms are a notice under the button instead of a checkbox; it now also covers the sign-ups with Google and GitHub Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- /events/new is open to visitors on the platform; self-hosted instances keep it behind the sign-in (only admins create events there) - The draft waits in the browser (src/lib/eventDraft.ts, without pictures); the last step leads to the sign-up, and afterwards the bazaar is created without another click - Organizer buttons on the landing and pricing pages lead into the wizard instead of the register page Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Review-Apphttps://review-234.bazarpro.de Modus: platform (wie bazarpro.de). Self-Hosting testen: Label Stand:
Laufendes Event mit allen Funktionen: Fahrradbörse Bürgerhalle (alle Funktionen). 📬 Alle Mails der Review-App: https://review-234-mail.bazarpro.de (Benutzer Die Review-App wird beim Schließen des Pull Requests entfernt. |
- Reset and change password ask like the sign-up: one field with show/hide (PasswordInput) and at least 10 characters (MIN_PASSWORD_LENGTH); the composition rules and the strength meter are gone - Unused texts removed, E2E specs follow Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Migration 0016 adds events.country (ISO code; none is Germany), the backend accepts DE, AT, CH, LI and LU - The form has a country select and checks the postal code per country (five digits in Germany, four in the others) - JSON-LD uses it as addressCountry instead of a fixed DE Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…last - Templates for what most organizers run, most asked first: children's bazaar, clothing/second-hand bazaar, ski bazaar, bike sale; the bike market with record is gone as template (its switches stay) - Illustrated template cards with highlights; drawn items (kids clothes, jacket, skis, bike) in components/illustrations - Order: kind, sale, items, fees, joining, then date and place, drop-off and a preview of the bazaar page; done steps can be opened from the stepper - Next to each step a live preview: the item on a buyer's phone with discount, VB, price offer and questions; the printed label; the payout of one item; the listing card; the page header; the drop-off timeline - The contact moved to the details, the commission to the fees Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Twelve drawings after real photos, three per kind: e.g. skis with toe and heel piece and poles with baskets, a forward-leaning ski boot with buckles and sole lips, a ski helmet with ear pad and goggles, Chelsea boots, a kids bike with training wheel; one shared box, so the sizes match everywhere - Cards and page headers show the three items as a group, the previews the item of each example (handbag and bike helmet replace coffee set and trailer) - Every new step scrolls to the top after it rendered, also when a template is picked; the template's name starts the title - /events/new?type=<id> starts with that template Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- New section with the four kinds of bazaars and their items; a card opens the creation wizard with that template - The hero headline follows the screen width, so "Second-Hand-Basare" no longer pushes the page wider than the phone - Phones in the hero and the process scenes are wider on small screens (114/130 -> 143-163 px) with a shorter screen, so their texts fit Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Kids: striped T-shirt and denim dungarees with rolled-up legs, building bricks in isometric view with studs, chunky red rubber boots with dots - Chelsea boots: low shaft and long toe sloping down from the instep, tall elastic U, pull tab, welted sole and low heel - Bike helmet: high shell with a short tail, rows of teardrop vents, visor at the forehead, rim, retention dial and straps - Group shots keep the side items inside the picture Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… helmet - T-shirt with sloping shoulders, angled sleeves and a wider body - Rubber boots with a thin sole attached to the foot, a pair in one color - Jacket laid flat with a stand-up collar instead of hanger and hood - Women's ankle boots with a heel: side zip, thin sole, one color - A U-lock replaces the bike helmet as third example of the bike sale Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…in the wizard The discount start was asked before the dates and checked against them, so the wizard could not go on: it now follows the dates and needs them to be set. Each step only checks the fields it shows. The last step gets cover templates, which also work without an account, and uploads for own cover and site plan that ask for the login. The previews show them and are clearly marked, their notes no longer sit on the dotted background. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…st banner Kids, clothing, bike and market covers are now the Unsplash photos of the demo data; ski and the tile pattern stay drawn. The hero in the preview had a minimum height and a ratio, which made it wider than its column. On phones the wizard grid could grow past the screen. The guest banner is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 tasks
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worum geht's
Mehr Besucher über die Suche, und weniger Absprünge bei Anmeldung und Registrierung. Sechs Teile und zwei Nachträge, je ein Commit:
1. SEO (
feat(seo))noindex, Besucher landen weiter auf der Startseite.src/shared/appRoutes.tslistet die Routen der App, ein Test hält die Liste mitApp.tsxgleich.2. Adresse für Basare (
feat(events))0015_event_address.sqlmitstreet,postal_code,city. Das bisherigelocationwird zum Namen des Veranstaltungsorts („Turnhalle Nord“).createEvent/editEventnehmen ein optionalesaddressan. Fehlt es, bleibt die gespeicherte Adresse, damit ältere App-Versionen sie beim Bearbeiten nicht löschen.locationvorbefüllt.PostalAddress. Die Suche findet auch die Adresse.3. Anmeldung und Registrierung (
feat(auth))OAuthButtons). Ein Klick meldet an oder legt das Konto an, danach geht es zurück zum Ziel. Ohne konfigurierten Anbieter erscheint nichts.4. Basar anlegen ohne Konto (
feat(events))/events/newist auf der Plattform ohne Login erreichbar. Self-hosted bleibt er hinter dem Login, weil dort nur Admins Events anlegen.localStorage(src/lib/eventDraft.ts), 14 Tage lang, ohne Bilder. Titelbild und Lageplan sind für Gäste ausgeblendet und kommen nach dem Anlegen dazu.?redirect=/events/new?draft=1). Danach wird der Basar ohne weiteren Klick angelegt, inklusive Lagerorten.5. Nachtrag: eine Passwortregel überall (
feat(auth))PasswordInput), mindestens 10 Zeichen (MIN_PASSWORD_LENGTH).6. Nachtrag: Land der Adresse (
feat(events))0016_event_country.sqlmitevents.country(ISO-Code, leer = Deutschland). Erlaubt sind DE, AT, CH, LI und LU.addressCountrykommt aus dem Feld statt festDE.7. Neuer Wizard zum Anlegen (
feat(events))components/wizard/WizardPreviews.tsx), am Handy unter den Einstellungen:components/illustrations), lizenzfrei und in hellem und dunklem Design.8. Zeichnungen, Scrollen im Wizard, Startseite am Handy
Zeichnungen neu: zwölf Stück nach echten Fotos, drei pro Basar-Art, zum Beispiel:
Alle in derselben Box, damit die Größen überall passen. Karten und Seitenköpfe zeigen die drei als Gruppe, die Vorschauen bei jedem Beispielangebot den passenden Artikel.
Wizard am Handy: Jeder Schritt startet oben, auch beim Wählen einer Vorlage. Gescrollt wird erst nach dem Rendern, damit ein kürzerer Schritt das Scrollen nicht abbricht. Der Name der Vorlage ist der Anfang des Titels.
/events/new?type=skiBazaarstartet direkt mit einer Vorlage.Startseite:
9. Rabatt-Tag, Bilder und deutlichere Vorschau im Wizard
components/wizard/WizardPictures.tsx): sechs Titelbild-Vorlagen, auch ohne Konto wählbar: vier Fotos aus den Demo-Daten (Unsplash) und zwei Zeichnungen (Ski, Kacheln); die passende zur Basar-Art ist vorausgewählt. Beim Anlegen wird die Vorlage wie ein eigenes Bild hochgeladen, schlägt das fehl, entsteht der Basar ohne Bild.public/images/covers, Foto-IDs insrc/lib/eventCovers.ts, Zeichnungen ausscripts/event-covers.Datenbank
0015_event_address.sql:street,postal_code,cityanevents0016_event_country.sql:countryaneventsBeide Spalten sind neu und leer. Das Land hat eine eigene Migration, damit eine schon eingespielte
0015(z. B. in der Review-App) gültig bleibt.Getestet
tsc,eslintund alle 489 Unit-Tests grün, Build läuft. Neu getestet:?type=, Scrollen nach obencargo fmtundclippysauber.noindex.fillEventWizardist auf die neue Reihenfolge angepasst. Die Specs für Registrierung, Passwort zurücksetzen und Passwort ändern sind auf die neuen Formulare angepasst. Durchgeklickt habe ich die Änderungen auch nicht. Bitte vor dem Merge in der Review-App prüfen: Registrierung mit Google, Gast-Wizard bis zum Anlegen, Kasse offline.Bewusst offen
https://bazarpro.de/logo.pngaus diesem PR, also diesen PR zuerst deployen.🤖 Generated with Claude Code