fix(migration): geonameId column name + widen Relations to VARCHAR(255) - #479
Closed
Neophytis wants to merge 275 commits into
Closed
fix(migration): geonameId column name + widen Relations to VARCHAR(255)#479Neophytis wants to merge 275 commits into
Neophytis wants to merge 275 commits into
Conversation
* Add check for phone number in CommentModel * Add check for phone number in CommentController * Add anti-spam check in RelationsController Added functions to check for email address and phone number, and only add the comment if none are detected
…ved to spam on block word.
…nd make forum work with strict mode for DB.
Bumps [squizlabs/php_codesniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) from 3.13.5 to 3.13.6. - [Release notes](https://github.com/PHPCSStandards/PHP_CodeSniffer/releases) - [Changelog](https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/4.x/CHANGELOG-3.x.md) - [Commits](PHPCSStandards/PHP_CodeSniffer@3.13.5...3.13.6) --- updated-dependencies: - dependency-name: squizlabs/php_codesniffer dependency-version: 3.13.6 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fixed bun audit failures * Sitemap generator including newsletters * Sitemap generator including newsletters
…(255) MigrateDatabaseCommand.migrateAddressTable queried g.geoname_id (snake_case) but the Location entity maps @Orm\Column(name="geonameId") and Lion's DB has the column as geonameId. Renaming the column in preflight was the wrong fix — it would break Doctrine. Query the column by its actual name instead. Version20260801120000: Relations SET→VARCHAR used VARCHAR(87) which is the theoretical maximum but caused data truncation on production data. Widened to VARCHAR(255) for both the new `comment.relations` and the Lion `comments.Relations` columns.
Neophytis
marked this pull request as draft
August 15, 2026 18:07
Contributor
Author
|
Closing: these files (MigrateDatabaseCommand.php, Version20260801120000.php) exist only on develop, not on master or feature/docker-beta. Shevek owns the develop migration system. No changes from master perspective are needed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs in the DB migration path, identified during the Lion→Alpha DB migration work and confirmed by Shevek's review.
Bug 1 —
MigrateDatabaseCommand: wrong column name for geonameIdmigrateAddressTable()was queryingg.geoname_id(snake_case) but:Locationentity maps@ORM\Column(name="geonameId")— camelCasegeonameIdThe previous workaround was renaming the DB column in preflight, which would have broken Doctrine entirely. The fix is to query the column by its actual name.
Bug 2 —
Version20260801120000:RelationsVARCHAR(87) too shortThe SET→VARCHAR migration used VARCHAR(87) for
comment.relationsandcomments.Relations. Production data caused truncation. Widened to VARCHAR(255).Test plan
bin/console migrate:databaseagainst a Lion DB copy — address ETL completes without "Unknown column 'g.geoname_id'" errordoctrine:migrations:migrate— Version20260801120000 applies without truncation warnings