Repository navigation
Build with JDK 25 in CI - #437
Merged
Merged
Conversation
BentoBox 3.23 and later are compiled for Java 25 (class version 69), so JDK 21 cannot compile against them. Use JDK 25 in the build, Modrinth publish and e2e workflows so the next BentoBox bump doesn't break CI. The addon still targets Java 21 bytecode. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BentoBox 3.23 and later are compiled for Java 25 (class version 69). JDK 21 can't compile against them, so CI fails with
class file has wrong version 69.0, should be 65.0as soon as the BentoBox version is bumped. Limits hit this in BentoBoxWorld/Limits#305.This PR moves the build, Modrinth publish and e2e workflows to JDK 25. The pom's
java.versionstays at 21, so the addon still compiles to Java 21 bytecode. The e2e Gradle wrapper (9.7.0) already supports JDK 25.Local
mvn clean packageon JDK 25: all 528 tests pass.🤖 Generated with Claude Code