Repository navigation
fix(cli): emit RequestModel schema leaves and type-only imports - #146
Merged
Merged
Conversation
The generated SDK file now describes each endpoint with
`RequestModel<{ ... }>` as documented, instead of a raw `Request<...>`
with positional generics. `ClientInstance` and `RequestModel` are
imported with `import type`, so the output compiles under
`verbatimModuleSyntax`. `SdkSchema` drops its `Client` generic because
`createSdk` injects the client into every leaf.
Closes #145
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
🎉 This PR is included in version 9.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #145.
RequestModel<{ response; payload; queryParams; error; endpoint }>, matching the SDK docs. Absent fields are omitted; optional query params becomequeryParams?:.ClientInstanceandRequestModelare imported withimport type, so the generated file compiles withverbatimModuleSyntaxenabled.SdkSchemano longer takes aClientgeneric. Core'screateSdkinjects the client into every leaf, so the parameter was redundant. If you referencedSdkSchema<typeof client>in your own code, drop the argument.Test plan
pnpm vitest runinpackages/cli(35 passed)oxlintandtsc --noEmiton the CLI packagesdk.pet.$petId.$get, withstrictandverbatimModuleSyntaxenabled against the built core package🤖 Generated with Claude Code