Skip to content

Hoist Gandalf logs and clean up common logs - #200

Open
tokebe wants to merge 3 commits into
mainfrom
logging
Open

Hoist Gandalf logs and clean up common logs#200
tokebe wants to merge 3 commits into
mainfrom
logging

Conversation

@tokebe

@tokebe tokebe commented Aug 17, 2026

Copy link
Copy Markdown
Contributor
  • Removed/merged some logs, reduced others INFO -> DEBUG
  • BaseQuery now merges logs produced by query implementation, wrapped between debug-level <Begin backend-produced logs> and <End of backend logs>
  • Gandalf query now returns Gandalf-produced logs

tokebe added 2 commits August 17, 2026 16:34
Merges some redundancies and downgrades some levels
@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/retriever/utils/logs.py 10.00% 9 Missing ⚠️
src/retriever/data_tiers/tier_0/base_query.py 0.00% 5 Missing ⚠️
src/retriever/lookup/utils.py 0.00% 4 Missing ⚠️
Files with missing lines Coverage Δ
src/retriever/data_tiers/tier_0/gandalf/query.py 71.42% <ø> (ø)
src/retriever/lookup/lookup.py 25.53% <ø> (+0.13%) ⬆️
src/retriever/lookup/qgx.py 20.82% <ø> (+0.05%) ⬆️
src/retriever/types/general.py 100.00% <100.00%> (ø)
src/retriever/lookup/utils.py 45.97% <0.00%> (+2.02%) ⬆️
src/retriever/data_tiers/tier_0/base_query.py 30.18% <0.00%> (-2.47%) ⬇️
src/retriever/utils/logs.py 42.85% <10.00%> (-3.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/retriever/lookup/lookup.py

@maximusunc maximusunc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running this locally with an updated Shepherd for a full log trace. I'm noticing that in some cases there seem to be two Gandalf queries included in the same shepherd query. I can only see one set of logs from Retriever, so it makes me believe those two log traces are getting combined in either Gandalf or Retriever. Could we investigate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants