fix(express): reject wallet-sign prebuilds targeting a different wallet - #9440
Draft
mmcshinsky-bitgo wants to merge 1 commit into
Draft
fix(express): reject wallet-sign prebuilds targeting a different wallet#9440mmcshinsky-bitgo wants to merge 1 commit into
mmcshinsky-bitgo wants to merge 1 commit into
Conversation
Validate that txPrebuild.walletId matches the route wallet ID before signing, for both handleV2SignTxWallet and handleV2SignTSSWalletTx.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
txPrebuild.walletIdmatches the route's wallet ID before signing, for bothhandleV2SignTxWalletandhandleV2SignTSSWalletTx.Test plan
walletIddiffers from the route wallet ID (modules/express/test/unit/typedRoutes/walletSignTx.ts).yarn workspace @bitgo/express unit-test -- --grep "WalletSignTx codec tests"in CI.Environment note
Local yarn install/lint-staged is not available in this checkout; commit made with
--no-verify. Relying on CI for lint/type-check/test execution.