Repository navigation
fix(models): keep legacy MiniMax routes explicit-only - #489
octo-patch wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
VickyXAI
left a comment
There was a problem hiding this comment.
Thanks for the thorough write-up, but we're not taking this one.
ClawRouter follows BlockRun's catalog rather than setting its own model visibility. Both public gateways (Base and Solana) list minimax/minimax-m2.7 today as available and not hidden, and blockrun's models.ts has it available: true. Hiding it from discovery here would make the proxy disagree with the gateway it fronts. If M2.7 is going to be retired from the picker, that starts in blockrun and ClawRouter syncs to it.
Separately, the change adds a third visibility mechanism (explicitOnly). That means config-walking pin preservation duplicated across src/index.ts, scripts/reinstall.sh and scripts/update.sh, plus a new failure mode: syncAgentModelCache now returns early on an unreadable openclaw.json, so a malformed config skips the per-agent cache repair entirely. That's a lot of surface to hide one model the upstream still sells.
(minimax/minimax-m2.5 is already gone from both catalogs; dropping it from BLOCKRUN_MODELS would fit in a routine catalog sync if you'd like to send that on its own.)
Reason: MiniMax M2.7 is still promoted in the default picker and API discovery alongside M3. Keep M3 as the current advertised MiniMax text option while preserving explicit legacy selections and their gateway metadata.
The public Base catalog and Solana catalog were checked again on 2026-10-20 before publication. Neither lists a MiniMax Flash route, so this PR does not claim Flash support or invent an ID. M3 retains the gateway's context 1,048,576, maximum output 65,536, and $0.30/$1.20 per-million input/output prices; direct-provider limits/prices are not substituted.
Validation:
npm ci --ignore-scripts.npm teston the final merged head — 1,235 passed, one skipped; hermetic suite.npx vitest run --config vitest.integration.config.ts test/integration/security-scanner.test.ts— both static scanner tests passed.npm run typecheck,npm run lint,npm run buildand distribution smoke checks — passed.npx prettier --check .,node scripts/sync-brand-numbers.mjs --check, and shell syntax checks for both installer scripts — passed.No paid inference, wallet transactions, or live model capability probes were performed. Public catalog reads establish route availability and gateway metadata only; packaged desktop UI and external integration services were not exercised.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation