Skip to content

test(scanner): find OpenClaw's scanner in .mjs chunks - #490

Merged
VickyXAI merged 1 commit into
mainfrom
test/scanner-mjs-chunks
Oct 20, 2026
Merged

VickyXAI merged 1 commit into
mainfrom
test/scanner-mjs-chunks

Conversation

@VickyXAI

@VickyXAI VickyXAI commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

On Dependabot #486, the scanner check is the only one still red after #488 (Node 24). The test fails with Scanner not available: scanner chunk not found because openclaw 2026.10.4 now ships its dist chunks as .mjs (scanner-AFrN6W5N.mjs), and the test only matched scanner-*.js.

This makes the test accept both .js and .mjs. I ran it locally against both openclaw versions (the current pin and 2026.10.4 from #486), and both passed (2 tests each).

Summary by CodeRabbit

  • Tests
    • Updated scanner discovery coverage to recognize both .js and .mjs distribution chunks while preserving existing filename patterns.

openclaw 2026.10.x moved its dist chunks from .js to .mjs, so the scanner
test (which only matched scanner-*.js) found nothing and failed with
"scanner chunk not found" on Dependabot #486. Accept both extensions.
Verified locally against openclaw 2026.10.4 and the current pin: 2 passed.
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: BlockRunAI/ClawRouter/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ead80c02-1df7-43c3-820e-cabe8d50429c
📥 Commits

Reviewing files that changed from the base of the PR and between c88bd40 and 8cc9599.

📒 Files selected for processing: 1
  • test/integration/security-scanner.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The scanner chunk discovery test now accepts .mjs files in addition to .js files for both supported filename prefixes.

Changes: Scanner chunk discovery

Layer / File(s) Summary
Scanner chunk file filter
test/integration/security-scanner.test.ts
The test filter accepts .mjs files alongside .js files for the skill-scanner-* and scanner-* prefixes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 8cc95

The focused test change addresses module-extension discovery without introducing an actionable merge risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: updating the scanner test to find OpenClaw scanner chunks in .mjs files.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@VickyXAI
VickyXAI merged commit 42e3702 into main Oct 20, 2026
5 checks passed
@VickyXAI
VickyXAI deleted the test/scanner-mjs-chunks branch October 20, 2026 05:11
VickyXAI pushed a commit that referenced this pull request Oct 20, 2026
DeepSeek V4.1 Flash added; free v4-flash pins follow the free default (#487).
Catalog synced to the live gateway: six chat models, grok-imagine-video-1.5,
retired ids follow the gateway redirect (#485). CI and publish on Node 24
(#488), scanner test reads .mjs chunks (#490), tsup 9 / vitest 5 (#486).
dist/ rebuilt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant