Repository navigation
Replace "Rotate 90° clockwise" with "Flip vertical" in the View menu - #357
Merged
Merged
Conversation
Both the case viewer and the compare viewer now offer Flip horizontal and Flip vertical on the focused pane. Flip vertical uses the same toggle as flip horizontal (a second click un-flips) and logs "Flipped <pane> vertically" to the reading timeline. The rotate helpers (rotatePane90Clockwise, rotateFocused90) and the rotate icon import are removed, since nothing else called them. Tests: a viewer smoke test opens the View menu, checks that both flips are listed and no rotate item remains, and that Flip vertical calls only the vertical flip. Ablation: pointing the vertical handler at the horizontal flip fails that test. The helper mocks in the other viewer tests are renamed to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The View menu in both the case viewer and the compare viewer now offers Flip horizontal and Flip vertical on the focused pane. "Rotate 90° clockwise" is removed, together with
rotatePane90Clockwise,rotateFocused90and the rotate icon import, which nothing else used.Flip vertical toggles like flip horizontal (a second click un-flips) and logs "Flipped vertically" to the reading timeline. The camera state already carried
flipVertical, so live-room view sync needs no change.Tests
viewer.smoke.test.tsx: the View menu lists both flips, has no rotate item, and Flip vertical calls only the vertical flip.Not verified
The flip itself on a real scan in a browser: the tests mock the viewer.
No access-policy or backend change.