Repository navigation
Allow removing devices that are no longer on the gateway - #68
Merged
Merged
Conversation
Owner
|
Very good! You even included a README section! <3 Thanks for the fix! |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a wireless device is removed from the gateway or replaced (in my case a faulty A9MEM1570 F63 3P+N swapped for three A9MEM1560 1P+N tags), the old device stays in Home Assistant forever:
Config entry does not support device removal,because the integration does not implement
async_remove_config_entry_device.The only workaround so far is to delete and re-add the whole integration (see the comment in #50), which loses entity customisations (names, areas, energy dashboard, automations).
Change
hass.data[DOMAIN][entry_id]["present_devices"].async_remove_config_entry_deviceallows removal only if none of the device's identifiers are in that set:No change to unique IDs, entities or Modbus traffic.
Notes