QE-2133: Allow duplicate v4 details with unique test IDs - #1003
Merged
Merged
Conversation
github-actions
Bot
added
the
javascript
sarahboyd
force-pushed
the
syoung/v4-uniqueness
branch
from
September 14, 2026 14:32
98c67b0 to
d9c1ed7
Compare
sarahboyd
marked this pull request as ready for review
September 14, 2026 14:34
sarahboyd
enabled auto-merge (squash)
September 14, 2026 14:35
Contributor
Coverage ReportReportReport Validation |
|
🎉 This PR is included in version 6.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
d2l-github-release-tokens
Bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V4 validates duplicate details in code instead of using JSON Schema’s
uniqueItems, which is too slow for large LMS reports. Details with the sametestId, or identical details without atestId, are rejected. Otherwise-identical details with different IDs are allowed.LMS Unit tests were still running the
upload test report - finalize reportstep after 5 minutes, which is way too long. Hoping this speeds things up