GAUD-10477 iframed dialog resize - #7485
Conversation
…resh the measures when dialog is rendered within an iframe.
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
| }; | ||
|
|
||
| #updateSize = async() => { | ||
| if (this._inIframe && this.#ifrauDialogService) this._ifrauContextInfo = await this.#ifrauDialogService.showBackdrop(); |
There was a problem hiding this comment.
What does showBackdrop do when an ifrau service backdrop already exists?
There was a problem hiding this comment.
I see, despite the wait it sounds, it returns new context measurements (here). The showBackdrop code itself appears to ensure it never creates more than one backdrop for any given iframe id, though we could expose the getContextInfo on the service.
There was a problem hiding this comment.
Oh you were faster than me, I did the same research and arrived to the same piece of code. I agree with you on making perhaps the getContextInfo to be public. Thanks will look into this
There was a problem hiding this comment.
OK I have implemented a new approach using the new exposed method from the service!
dbatiste
left a comment
dbatiste
left a comment
There was a problem hiding this comment.
I've approved your other PR as well. It would be best to merge it first.
|
🎉 This PR is included in version 3.317.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
jira
GAUD-10477
Description
When zooming 200+,
d2l-dialog-fullscreendialogs that were being rendered within an iframe, were not getting resized, and thus getting cropped off. That was creating an accessibility issue.This PR solves that problem, by refreshing the
this._ifrauContextInfoso on the next rendering the dialog gets updated with the new available space.