Skip to content

test: add ConnectorBench MCP contract conformance suite - #7

Merged
BurhanAbdullah merged 10 commits into
mainfrom
feat/connectorbench-conformance-clean
Oct 14, 2026
Merged

BurhanAbdullah merged 10 commits into
mainfrom
feat/connectorbench-conformance-clean

Conversation

@BurhanAbdullah

Copy link
Copy Markdown
Owner

Summary

Introduces ConnectorBench, a dependency-light, read-only conformance inspector for MCP tool catalogs.

  • Validates tool names and detects duplicate registrations.
  • Checks input schema shape, required-property declarations, and JSON serializability.
  • Reports missing descriptions as warnings rather than failures.
  • Integrates the checks into the existing connector entrypoint smoke test.
  • Adds deterministic tests for valid catalogs and representative contract violations.

Safety and scope

  • The inspector never invokes connector tools or launches a solver.
  • No README files are changed.
  • This is separate from PSCAD lifecycle work and simulation-result comparison.

Validation

CI is required before this is considered ready to merge. Skipped or unsupported checks must not be treated as passing.

@BurhanAbdullah
BurhanAbdullah marked this pull request as ready for review October 14, 2026 05:07
Copilot AI balanced review requested due to automatic review settings October 14, 2026 05:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T05:09:00.074316Z 7a937cd Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a937cdac0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/connectorbench.py Resolved
@BurhanAbdullah
BurhanAbdullah merged commit 732adda into main Oct 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants