Repository navigation
Add StabiliNNator matrix coverage (S01-S03) - #117
Conversation
StabiliNNator ships in the same container but had NO matrix coverage, so '59/59 passed' silently meant one of the two apps. Its first real submission failed at dispatch (tasks 23450684, 23450690) long after folding_260821.3 was deployed and declared green. - submit_job takes a per-case 'app' key, defaulting to PredictStructure - S01/S02/S03 cover analysis_type both/proline/disulfide - the --include-alphafold filter no longer assumes every case has a 'tool' key - 1crn_small.pdb staged in the workspace inputs/ folder S01 currently FAILS against production, which is correct: it reports the partition => 'normal' dispatch bug the matrix could not see before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DEWo4xvL59PHC1QUvtTV9F
status == completed is not evidence a job produced anything. StabiliNNator reported success while uploading its results flat into output_path instead of the job folder, leaving output_files empty (tasks 23452794-23452798, CEPI-dxkb/stabiliNNatorApp#18) -- and S01-S03 went green on a job whose own folder was empty and whose report the UI cannot find. That is the same 'rc=0 is not enough' weakness this suite was added to close. - judge() now fails a completed job with empty output_files, and honours an optional expect_output suffix (S01-S03 require *_report.html) - fetch_output_files reads the job object via p3-cat, falling back to the folding container since p3-cat is not on the host PATH -- without that fallback the helper returned None every time and the assertion never ran, which it did on the first attempt - unreadable (None) is distinguished from empty ([]), so a workspace hiccup is not reported as a missing-output bug Verified both directions: S01 now FAILS with 'completed but no output_files'; E01 and B01 still PASS with real outputs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DEWo4xvL59PHC1QUvtTV9F
|
Updated — the cases now assert delivered outputs, not just Running S01-S03 against That is the same weakness I flagged in the acceptance harness earlier: asserting the exit code rather than the effect.
Verified both directions: S01 now FAILs with Still holding this PR: S01-S03 are red, correctly, until stabiliNNatorApp#18 is fixed. |
StabiliNNator ships in the same container as PredictStructure but had zero matrix coverage, so
59/59 passedsilently meant one of the two apps. Its first ever real submission failed at dispatch — tasks 23450684 and 23450690 — long afterfolding_260821.3was deployed and reported green.submit_jobtakes a per-caseappkey, defaulting toPredictStructureanalysis_typeboth / proline / disulfide--include-alphafoldfilter no longer assumes every case has atoolkey (it crashed withKeyError: 'tool'on the first non-PredictStructure case)1crn_small.pdbstaged into the workspaceinputs/folder so the cases follow the existing path conventionS01 currently FAILS against production, and that is the correct result — it reports the
partition => 'normal'dispatch bug that the matrix previously could not see. It should stay red untilApp-StabiliNNator.plis fixed.Companion change in runtime_build (
56b46ff): the acceptance harness now asserts the content ofpolicy_data.partitionrather than justrc=0, and goes red on the current container while PredictStructure passes the same check.612 passed, 10 skipped.