Skip to content

fix: let every PR hygiene run complete (5.x) - #208

Merged
CaffeinatedCoder merged 2 commits into
release/5.xfrom
fix/207-hygiene-cancels
Oct 29, 2026
Merged

CaffeinatedCoder merged 2 commits into
release/5.xfrom
fix/207-hygiene-cancels

Conversation

@CaffeinatedCoder

@CaffeinatedCoder CaffeinatedCoder commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Closes #207

Problem

pr-hygiene.yml cancelled every run but the last within its concurrency group (cancel-in-progress: true): 152 of the 200 runs before this PR. "Labels and issue link" is a required check on release/5.x and main, and each cancelled run left a CANCELLED check run on the commit.

Change

Keeps the group and sets cancel-in-progress: false, so the runs of one PR go one at a time and none that has started is cancelled. The workflow's header comment records why, from the measurements below.

Tests

Measured on this PR, which runs its own copy of the workflow.

  1. No group (first commit, d80aa07). Opened with labels, milestone and body in one gh pr create: four runs, all completed, none cancelled. Then the failure the issue warned of: a label removed and re-added gave a failing run and a passing one; re-running the failing run, so its old payload finished last, made FAILURE the check's latest result although the labels were in order. Without a group, runs finish in any order, and the last to finish decides.
  2. Serialized (cb3145d). A push, then three remove/add pairs of a label within 4 seconds: seven runs. They ran in event order, the last event's run (passing) finished last at 14:58:48, and the three runs cancelled while waiting left no check run on the commit. The commit's "Labels and issue link" check runs: success, failure, failure, success, in that order, the last deciding.

So a cancelled run can still appear in the Actions list, but only one that never started, and never as a check run.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CaffeinatedCoder CaffeinatedCoder added this to the 5.6.1 milestone Oct 29, 2026
@CaffeinatedCoder CaffeinatedCoder added bug Something isn't working severity/low Cosmetic, message or documentation-level difference area/release Versioning, changelogs, release wiring and removed severity/low Cosmetic, message or documentation-level difference labels Oct 29, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CaffeinatedCoder CaffeinatedCoder added severity/low Cosmetic, message or documentation-level difference and removed severity/low Cosmetic, message or documentation-level difference labels Oct 29, 2026
@CaffeinatedCoder
CaffeinatedCoder merged commit e548e53 into release/5.x Oct 29, 2026
15 of 17 checks passed
@CaffeinatedCoder
CaffeinatedCoder deleted the fix/207-hygiene-cancels branch October 29, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/release Versioning, changelogs, release wiring bug Something isn't working severity/low Cosmetic, message or documentation-level difference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant