Repository navigation
packaging(ns8): declare the data volume for cluster backup - #141
Merged
Merged
Conversation
This is a data-loss bug. NS8 passes only the volumes a module declares in etc/state-include.conf to restic. Without that file a backup of a populated instance reports success while omitting the SQLite database entirely. Measured live on a single-node cluster, same instance, same data: without etc/state-include.conf: 2 files, 476 bytes with etc/state-include.conf: 7 files, 2,163,292 bytes ns8-nextcloud declares its app-data volume the same way. Without this file a restore would have handed back an empty database, and Calnode's key vault would then be unlocking nothing. Backup capture is now verified live. The destroy-and-restore leg is still unverified and the README says so.
Contributor
|
Your provider account is out of credit. Pullfrog detected a billing-exhausted response from your provider — the agent stopped before completing this run. Top up your provider account, then re-trigger Pullfrog.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a data-loss bug. NS8 passes only the volumes a module declares in
etc/state-include.confto restic. Without that file, a backup of a populated instance reports success while omitting the SQLite database entirely.Measured live on a single-node NS8 cluster, same instance, same data, only the file added:
etc/state-include.confetc/state-include.confA restore from the first backup would have handed back an empty database, and Calnode's key vault would then be unlocking nothing. This is the same failure mode the module was written to avoid, and it survived because
add-module, configure, routing, persistence across reconfigure and removal had all been verified without ever running a backup.ns8-nextclouddeclares its app-data volume the same way.Also corrected the README, which claimed backup/restore was covered while it had never been run. It now records what was actually measured and marks the restore leg as still unverified.