Skip to content

fix(calendar): prefer the destination provider for meeting generation - #62

Merged
shockalotti merged 1 commit into
Calnode:mainfrom
marijnbent:fix/destination-meeting-provider
Sep 21, 2026
Merged

shockalotti merged 1 commit into
Calnode:mainfrom
marijnbent:fix/destination-meeting-provider

Conversation

@marijnbent

Copy link
Copy Markdown
Contributor

With more than one calendar provider connected, the meeting-link path can pick the first connection instead of the destination. For example, an older CalDAV connection can take precedence over a Google destination.

I changed the connected-provider lookup to prefer the destination, with creation time as a stable fallback. The test covers CalDAV connected before Google and switching the destination back. Calendar write routing is unchanged.

Validation: go test ./... and make build pass.

This is separate from #58: that issue is about moving or cancelling existing events after changing providers.

@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA. ✅
Posted by the CLA Assistant Lite bot.

@marijnbent

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@marijnbent
marijnbent marked this pull request as ready for review September 20, 2026 18:39
@pullfrog

pullfrog Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

This repo's model isn't fully set up yet.

OPENAI_COMPATIBLE_MODEL env var is required when the model is set to "openai-compatible/byok". set it to the model ID served by your OpenAI-compatible endpoint (e.g. a Cloudflare AI Gateway or DashScope model). see https://docs.pullfrog.com/openai-compatible for setup.

Configure model →

Pullfrog  | Rerun failed job ➔ | View workflow run | via Pullfrog | Using OpenAI-compatible | 𝕏

@marijnbent
marijnbent marked this pull request as draft September 20, 2026 18:41
@marijnbent
marijnbent marked this pull request as ready for review September 20, 2026 18:56
@marijnbent

Copy link
Copy Markdown
Contributor Author

recheck

@shockalotti
shockalotti merged commit 6d23c6b into Calnode:main Sep 21, 2026
1 of 3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 21, 2026
@shockalotti

Copy link
Copy Markdown
Contributor

Hi Marijn - quick heads-up beyond the review: your Sunday batch is the lead story in our v0.10.0 release announcement (ten PRs in sixteen minutes, CLA on all of them). We would name you by your GitHub handle with a link to your profile, nothing beyond what is public here. Cool with that, or prefer we keep it low-key? Either way the code stands on its own. Thanks again for the batch. - Wynne

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants