Skip to content

Remove unused -d/daemon-id and standardize peer_id/group_id in config - #174

Merged
mikelangmayr merged 2 commits into
mainfrom
mike/peer-group-naming-cleanup
Sep 5, 2026
Merged

Remove unused -d/daemon-id and standardize peer_id/group_id in config#174
mikelangmayr merged 2 commits into
mainfrom
mike/peer-group-naming-cleanup

Conversation

@mikelangmayr

Copy link
Copy Markdown
Contributor
  • remove -d/--daemon-id from pi-daemon, adc, piaa-gimbalmount, generic/filterwheel: confirmed no deployed config uses the daemons: subsystem style it selected between, only the never-deployed config/example/hsfei.yaml did
  • remove the hardcoded group_id = "hsfei" class attribute from PiDaemon/AdcDaemon/PiaaGimbalmount; group_id now comes from config only, consistently across all daemons
  • shorten peer_id in every hsfei config to just the scope (e.g. hsfei_pickoff -> pickoff) and add group_id: hsfei to the five configs that were missing it; every config now sets both explicitly, config file is the single source of truth
  • delete hispec/src/hispec/config.py (ConfigError, DaemonConfigLoader, extract_daemon_config, etc.): confirmed unused dead code, left over from before HispecDaemon delegated to libby's own config loading
  • depends on libby PR Add logging and tests to sunpower controller #23 (qualified_peer_id): once merged, these daemons' wire address becomes group_id.peer_id (e.g. hsfei.pickoff) instead of the old bare hsfei_pickoff - needs to deploy together with that libby change, not before it
  • verified end to end: from_config_file (no daemon_id arg) loads peer_id/group_id correctly for pi-daemon, adc, and piaa-gimbalmount against their real configs, and build_libby() produces the correct qualified wire identity for each

…g-cleanup

# Conflicts:
#	config/hsfei/hsfei_ATCFW.yaml
#	config/hsfei/hsfei_PIAAgimr.yaml
#	config/hsfei/hsfei_yjpiaagim.yaml
#	daemons/generic/filterwheel
#	daemons/hsfei/piaa-gimbalmount
@mikelangmayr
mikelangmayr merged commit 392a7d0 into main Sep 5, 2026
1 of 5 checks passed
@mikelangmayr
mikelangmayr deleted the mike/peer-group-naming-cleanup branch September 5, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants