Remove unused -d/daemon-id and standardize peer_id/group_id in config - #174
Merged
Conversation
mikelangmayr
commented
Sep 4, 2026
Contributor
- remove -d/--daemon-id from pi-daemon, adc, piaa-gimbalmount, generic/filterwheel: confirmed no deployed config uses the daemons: subsystem style it selected between, only the never-deployed config/example/hsfei.yaml did
- remove the hardcoded group_id = "hsfei" class attribute from PiDaemon/AdcDaemon/PiaaGimbalmount; group_id now comes from config only, consistently across all daemons
- shorten peer_id in every hsfei config to just the scope (e.g. hsfei_pickoff -> pickoff) and add group_id: hsfei to the five configs that were missing it; every config now sets both explicitly, config file is the single source of truth
- delete hispec/src/hispec/config.py (ConfigError, DaemonConfigLoader, extract_daemon_config, etc.): confirmed unused dead code, left over from before HispecDaemon delegated to libby's own config loading
- depends on libby PR Add logging and tests to sunpower controller #23 (qualified_peer_id): once merged, these daemons' wire address becomes group_id.peer_id (e.g. hsfei.pickoff) instead of the old bare hsfei_pickoff - needs to deploy together with that libby change, not before it
- verified end to end: from_config_file (no daemon_id arg) loads peer_id/group_id correctly for pi-daemon, adc, and piaa-gimbalmount against their real configs, and build_libby() produces the correct qualified wire identity for each
prkrtg
approved these changes
Sep 4, 2026
…g-cleanup # Conflicts: # config/hsfei/hsfei_ATCFW.yaml # config/hsfei/hsfei_PIAAgimr.yaml # config/hsfei/hsfei_yjpiaagim.yaml # daemons/generic/filterwheel # daemons/hsfei/piaa-gimbalmount
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.