Skip to content

filter non-chat models - #180

Open
minump wants to merge 2 commits into
mainfrom
164-model-picker-api
Open

minump wants to merge 2 commits into
mainfrom
164-model-picker-api

Conversation

@minump

@minump minump commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

filter non-chat models in chat page
have public api dialog box hide chat button for non-chat models.

Tested by running the backend and frontend in local. Added non-chat models to ModelDeployment table and tested if the chat button shows up and if the api dialogue box is populated correctly.

@minump minump linked an issue Nov 7, 2026 that may be closed by this pull request
@minump
minump requested a balanced review from Copilot November 7, 2026 00:41
@minump minump self-assigned this Nov 7, 2026
@minump minump added this to the 1.2 milestone Nov 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the changes restricting chat options and API examples to supported model types.

No open issues 🎉

What changed in this PR

This PR filters non-chat models from the chat picker and hides their Chat action on Active Models cards. It also prevents the public API dialog from showing chat-completions examples for unsupported model types.

Changes:

  • Centralizes chat-capability checks for LLM, VLM, and models with no declared type.
  • Filters chat deployment options and displays an unavailable-examples message for unsupported API types.
  • Adds unit coverage for model filtering, Chat button visibility, and endpoint selection.
File Description
frontend/​tests/​unit/​public-api-snippets.test.ts Tests unsupported endpoint selection for reward models.
frontend/​tests/​unit/​chat-models-route.test.ts Tests exclusion of non-chat deployments.
frontend/​tests/​unit/​active-model-card.test.tsx Tests Chat button visibility by model type.
frontend/​lib/​public-api-snippets.ts Returns no endpoint for unsupported model types.
frontend/​lib/​models/​types.ts Adds the shared chat-capability helper.
frontend/​components/​public-api-dialog.tsx Handles unsupported endpoints without showing request examples.
frontend/​components/​model-card/​active-model-card.tsx Shows Chat only for chat-capable models.
frontend/​app/​api/​chat/​models/​route.ts Filters deployments using catalog model types.
CHANGELOG.md Documents filtering, dialog behavior, and test coverage.

Review effort: Balanced

@minump
minump requested a review from joshfactorial November 7, 2026 01:13

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show only chat models in the chat page model picker

2 participants