Repository navigation
ExternalizableBean: do not retain oversized thread-local buffer after write - #52
Merged
Merged
Conversation
… write The thread-local BytesCache only shrank at the start of the next dynamic field write, so an idle thread kept a very large buffer indefinitely. Reset the buffer right after each dynamic field is written; reset() drops the backing array if its capacity exceeds BYTES_CACHE_MAX_RETAINED_CAPACITY (1 MB). If a field fails to write, the thread-local StreamCache is replaced by a fresh one, since its ObjectOutput may hold partial state. Add tests for the retention behavior (including worker threads, nested beans, failed writes and the capacity boundary) and a manual multi-threaded stress tester, ExternalizationBufferStressTester. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
cojosh
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thread-local BytesCache only shrank at the start of the next dynamic field write, so an idle thread kept a very large buffer indefinitely.
Reset the buffer right after each dynamic field is written; reset() drops the backing array if its capacity exceeds BYTES_CACHE_MAX_RETAINED_CAPACITY (1 MB). If a field fails to write, the thread-local StreamCache is replaced by a fresh one, since its ObjectOutput may hold partial state.
Add tests for the retention behavior (including worker threads, nested beans, failed writes and the capacity boundary) and a manual multi-threaded stress tester, ExternalizationBufferStressTester.