Repository navigation
hotfix: allow saving long summaries and descriptions on prod - #283
Merged
Merged
Conversation
Use case and collaborative summaries can be up to 200,000 characters, but their search mapping kept a keyword-analyzed raw copy that turns the whole value into one token, and Elasticsearch rejects tokens over 32,766 bytes. Saving a published item with a long summary returned an error. Removes those raw sub-fields from the long text fields of all search documents (same change as #278 and #281 on dev) and adds migration 0054, which drops and recreates any live index still carrying one; the deploy then refills it. Fixes #266
Contributor
|
@anantjain341 this is live on prod now (cbdc87c, deploy finalized). Follow-up from the PR description: dev already has 0054–0059, so main's |
Contributor
Author
|
@saqibmanan Thanks. The back-merge with the merge migration is up as #286. It needs to go into dev before #279 or any other dev to main release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #266 on production.
Use cases and collaboratives with a long summary (and items with a long
description) cannot be saved on prod: the save returns an error. The search
index refuses text over about 32,000 bytes, and saving a published item writes
it to search.
This is only that fix from dev (#278, #281), nothing else from dev.
Changes
rawsub-field in allsearch documents.
0054_rebuild_long_text_search_indexes: drops and recreates any liveindex that still has such a sub-field; the deploy then refills it. Elasticsearch
only, no database change. Errors are logged and never fail the migration.
After deploy
Before the next dev to main release, main must be merged back into dev with a
merge migration (follow-up PR into dev), so there is a single migration leaf.