Repository navigation
chore(a11y): remove homepage checks that only scanned the skeleton, un-xfail fixed UX-011 - #21
Draft
saqibmanan wants to merge 3 commits into
Draft
saqibmanan wants to merge 3 commits into
saqibmanan wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes accessibility checks that can never fail, and turns a fixed bug's xfail back into a plain test.
Changes
tests/accessibility/test_accessibility.py:test_homepage_has_no_critical_axe_violations,test_images_have_alt_text,test_buttons_have_accessible_names,test_feature_tabs_have_aria_states.HomePage.go_to_homereturns atload, before hydration, so they all scanned an empty skeleton (0 img, 0 button, 0 h1). The axe scan passed on nothing, two checks always skipped with "Norole=tab. test: hydrated homepage a11y, sign-in page, mobile menu and API host header coverage #19 replaces them with checks that run on the hydrated page and fail when a regression is injected.reports/accessibility_report.json, which only the removed axe test wrote (README updated).test_ux011_new_evaluation_dialog_selects_have_labelsnow passes on dev; withxfail_strict = trueits xfail turned into a failure and was one cause of the red "Test Summary" job. The mark is removed so the check runs as a regression test.Checks (dev, 2026-11-05)
test_ux011_...: 3/3 passed.tests/accessibility/test_accessibility.py:3 passed, 1 skipped, 3 xfailed.pytest tests --collect-only: 848 collected.Until #19 merges, the homepage has no axe scan; the removed one never scanned the real page.