Add link back to start page on 404 error page (#107) - #321
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 4 reviews per rolling hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe 404 error view now includes a paragraph with a link to return to the start page. Changes404 error navigation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change adds a translated link from the 404 page back to the dashboard start page. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Checked for outstanding review feedback on this PR: there are no review threads and no reviews requesting changes — CodeRabbit's only comment states "No actionable comments were generated in the recent review." Nothing to address. |
|
Hi @aheinze — noticed this PR doesn't have a reviewer assigned yet — it's been about 4 days, CI is green and it's mergeable. Would you (or whoever's best placed) be able to take a look, or point me to who should? Thanks! |
What
Adds a link back to the start page (admin dashboard root) on the 404 error page (
modules/App/views/errors/404.php).Why
Closes #107. Currently the 404 page is a dead end — no way to navigate back into the app without manually editing the URL.
Implementation notes
$this->route('/')helper for the link target, matching the existing pattern used elsewhere in the codebase for linking to the dashboard/start page (seemodules/App/layouts/app.php, e.g.<a href="<?= $this->route('/') ?>" aria-label="<?= t('Dashboard') ?>">). This resolves to the admin dashboard root, which is the correct "start page" target given this view lives undermodules/App/views/errors/(the admin-side error view) — there is no separate public-site 404 template in the codebase.t('Back to start page').Testing
php -lsyntax check passed (PHP 8.3, matching thecomposer.json"php": "^8.3.0"requirement), viadocker run --rm -v $(pwd):/app -w /app php:8.3-cli php -l modules/App/views/errors/404.php.Summary by CodeRabbit