Repository navigation
Keep the folders in attachment names that Outlook writes unescaped - #54
Merged
Merged
Conversation
Outlook names a file attached from a folder after its Windows path and doesn't escape the backslashes, so the 74-attachment mail behind #52 listed zpo-berufung\reference\akt.md as zpo-berufungreferenceakt.md and two LIESMICH.md files in different folders looked the same. SwiftMail #254 keeps those backslashes for both .eml files and IMAP. It is now part of the SwiftMail 1.16.0 release, so the pin moves to its commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outlook names a file attached from a folder after its Windows path and doesn't escape the backslashes:
Read strictly as RFC 2045 quoted pairs,
\rbecomesr. The 74-attachment mail behind #52 therefore listedzpo-berufungreferenceakt.md, and twoLIESMICH.mdfiles in different folders looked the same.Change
88c45cb, which adds Keep backslashes in filenames that Outlook writes unescaped SwiftMail#254 on top of #253. It keeps those backslashes when parsing.emlfiles. Over IMAP, Dovecot has already dropped them from BODYSTRUCTURE, sofetchStructurerestores them from each named part's MIME header. The SwiftMail 1.16.0 tag moves to this commit so the release includes it.Verified
swift test: 63 run, 4 skipped, 0 failures.post fetch 21835 --server drobniklistszpo-berufung\training\README.md,zpo-berufung\training\entscheidungen\LIESMICH.md, … instead ofzpo-berufungtrainingREADME.md.post listis unchanged.🤖 Generated with Claude Code