fix: do not index WP_Error when polling optimized images - #1134
Open
selul wants to merge 1 commit into
Open
Conversation
get_optimized_images() can return WP_Error or false on transport and API failures. Guard poll_optimized_images() so dashboard polling degrades to an empty list instead of fatalling. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_optimized_images(), which is documented to returnarray|bool|WP_Error, then indexed$images['list']with no type check. Transport failures and non-200 API error payloads therefore fatal withCannot use object of type WP_Error as array(inc/rest.php:712).WP_Error, non-arrays, and missing/empty lists the same as “no images”: return a successful REST payload with an empty list so the dashboard widget degrades instead of crashing.WP_Errorresponses #1125 (3 sites). This is a standing type hole, not an update/OPcache race.Fixes #1125
Test plan
composer phpunit -- --filter=Test_Poll_Optimized_Images(transportWP_Error, API error payload, empty body, missing/empty list, successful list)inc/rest.php, PHPStanMade with Cursor