Repository navigation
Probeable toast: stop leaking the pass count of locked tests - #193
Merged
Merged
Conversation
The ladder hides every test after the first failure, but the grading
toast still said "{passed}/{total} tests passed" over all tests, so a
student who failed test 1 learned that 6 of the 7 tests passed. The
toast now reports counts only when everything passed. Otherwise it names
the failing test and the number of locked tests, which is exactly what
the ladder shows. B17 asserts the new warning text.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
For probeable problems the grading toast said
{problem}: {passed}/{total} tests passedacross all tests, while the ladder deliberately hides everything after the first failure. Failing test 1 with six more locked produced a toast saying "6/7 tests passed", which told the student how the locked tests fared.The toast now reports counts only when every test passed (nothing is locked then). Otherwise it names the failing test and the locked count:
Problem 3: test 1 failed · 3 more locked, or… test 4 failedwhen it was the last. Two i18n keys added in both locales. EiPL, Prompt, MCQ and Debug/Fix toasts are untouched.Verification
Same leak, not fixed here
The attempts dropdown shows
tests_passed/total_testsand the score badge for every attempt, and the result payload carries the full counts. For a first-test failure the badge reads 75% and the row reads 3/4. Hiding those changes what a grade means to the student, so it is a product call rather than a bug fix. If the ladder's rule is meant to hold, the backend should stop sending counts beyond the first failure for probeable types and the dropdown should show "stopped at test n" instead.🤖 Generated with Claude Code