Repository navigation
Fix normal and large text sizing definitions in contrast-master to match WCAG SC 1.4.3 - #206
Closed
AdamMagued wants to merge 1 commit into
Closed
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
…tch WCAG SC 1.4.3
AdamMagued
requested review from
accesswatch and
taylorarndt
as code owners
September 28, 2026 17:35
Author
|
closing this one in favor of #214 where i updated the full reference docs and validation checklist alongside the skill. sorry for the duplicate PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #198
Summary of Change
In
skills/contrast-master/SKILL.md, the text sizing thresholds previously defined normal text as(under 18px or under 14px bold)and large text as(18px+ or 14px+ bold).As reported in #198, this conflated point (
pt) values with CSS pixel (px) values. Under WCAG SC 1.4.3:This updates the thresholds in
contrast-master/SKILL.mdto accurately reference both pixel and point equivalents, aligning with existing reference documentation in the repository.Verification
npm run verify:skills(validated 108 skills)npm run verify:conformance(frontmatter conformant)npm run verify:mcp(107/107 tests passed)npm run verify:findings,npm run verify:report, andnpm run verify:budgets(all passed)