Skip to content

🎨 Palette: μ™ΈλΆ€ 링크에 μ ‘κ·Όμ„± 높은 μ‹œκ°μ  μ§€μ‹œμž μΆ”κ°€ - #249

Closed
seonghobae wants to merge 3 commits into
mainfrom
palette/external-links-17032232233785507054
Closed

seonghobae wants to merge 3 commits into
mainfrom
palette/external-links-17032232233785507054

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

πŸ’‘ What: μ™ΈλΆ€ 링크(target="_blank")λ₯Ό κ°€μ§„ <a> νƒœκ·Έ ν…μŠ€νŠΈ μ˜†μ— μƒˆ μ°½ 열림을 λ‚˜νƒ€λ‚΄λŠ” μ‹œκ°μ  μ§€μ‹œμž(β†—)λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€. λ ˆμ΄μ•„μ›ƒμ— 직접적인 영ν–₯을 μ£Όμ§€ μ•Šλ„λ‘ 일반 λ§ν¬μ—λ§Œ μ μš©ν•˜κ³  .button μš”μ†ŒλŠ” μ œμ™Έν–ˆμŠ΅λ‹ˆλ‹€. λ²ˆμ—­(i18n) μ‹œμŠ€ν…œκ³Όμ˜ μΆ©λŒμ„ λ°©μ§€ν•˜κΈ° μœ„ν•΄ ν…μŠ€νŠΈλ₯Ό <span>으둜 λΆ„λ¦¬ν•˜μ—¬ κ°μŒŒμŠ΅λ‹ˆλ‹€.

🎯 Why: μ‚¬μš©μžκ°€ 링크λ₯Ό ν΄λ¦­ν•˜κΈ° 전에 μ™ΈλΆ€ μ‚¬μ΄νŠΈλ‘œ μ΄λ™ν•˜κ±°λ‚˜ μƒˆ 창이 μ—΄λ¦°λ‹€λŠ” 점을 미리 인지할 수 μžˆλ„λ‘ ν•˜μ—¬ 예츑 κ°€λŠ₯μ„±κ³Ό μ‚¬μš©μ„±μ„ ν–₯μƒμ‹œν‚€κΈ° μœ„ν•¨μž…λ‹ˆλ‹€.

πŸ“Έ Before/After: ν•΄λ‹Ή 링크듀은 기쑴에 일반 ν…μŠ€νŠΈλ‘œλ§Œ ν‘œμ‹œλ˜μ—ˆμœΌλ‚˜, 이제 μš°μΈ‘μ— μž‘μ€ β†— μ•„μ΄μ½˜μ΄ ν•¨κ»˜ ν‘œμ‹œλ˜μ–΄ μ™ΈλΆ€ λ§ν¬μž„μ„ λͺ…ν™•νžˆ λ‚˜νƒ€λƒ…λ‹ˆλ‹€.

β™Ώ Accessibility: μ‹œκ°μ  μ§€μ‹œμžλŠ” 화면을 λ³΄λŠ” μ‚¬μš©μžμ—κ²Œλ§Œ μœ μš©ν•˜λ―€λ‘œ aria-hidden="true" 속성을 μΆ”κ°€ν•˜μ—¬ 슀크린 λ¦¬λ”μ—μ„œλŠ” λ¬΄μ‹œλ˜λ„λ‘ μ²˜λ¦¬ν–ˆμŠ΅λ‹ˆλ‹€. 슀크린 리더 μ‚¬μš©μžμ—κ²ŒλŠ” 이미 μ‘΄μž¬ν•˜λŠ” .visually-hidden ν…μŠ€νŠΈμ™€ aria-describedby="new-window-desc" 속성을 톡해 "μƒˆ μ°½μ—μ„œ μ—΄λ¦Ό"μ΄λΌλŠ” 정보가 μΆ©λΆ„νžˆ 제곡되고 μžˆμœΌλ―€λ‘œ μ •λ³΄μ˜ 쀑볡을 λ°©μ§€ν–ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 17032232233785507054 started by @seonghobae

Summary by CodeRabbit

  • μƒˆ κΈ°λŠ₯

    • μ™ΈλΆ€ 링크에 μƒˆ μ°½μ—μ„œ 열림을 λ‚˜νƒ€λ‚΄λŠ” β†— μ‹œκ°μ  ν‘œμ‹œλ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
    • GitHub 탐색, μ°Έκ³ λ¬Έν—Œ, 곡개 ν”„λ‘œμ νŠΈ, Fork ν”„λ‘œμ νŠΈ 및 μ„€λ¦½μž 링크에 ν‘œμ‹œλ©λ‹ˆλ‹€.
  • κ°œμ„  사항

    • λ‹€κ΅­μ–΄ λ²ˆμ—­μ—μ„œλ„ μ™ΈλΆ€ 링크 μ•ˆλ‚΄ ν‘œμ‹œκ°€ μœ μ§€λ˜λ„λ‘ λ²ˆμ—­ ν…μŠ€νŠΈμ™€ μ‹œκ°μ  ν‘œμ‹œλ₯Ό λΆ„λ¦¬ν–ˆμŠ΅λ‹ˆλ‹€.
    • ν”„λ‘œμ νŠΈ 및 Fork 링크의 λ²ˆμ—­ 지원을 κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 92970e37-bd13-429c-86f4-4d4d553ec45e

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 7c4251d and 41a910b.

πŸ“’ Files selected for processing (2)
  • .Jules/palette.md
  • index.html

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


πŸ“ Walkthrough

Walkthrough

μ™ΈλΆ€ 링크에 μƒˆ 창을 λ‚˜νƒ€λ‚΄λŠ” β†— ν‘œμ‹œλ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€. ν”„λ‘œμ νŠΈ 및 Fork λ§ν¬λŠ” λ²ˆμ—­ λŒ€μƒ ν…μŠ€νŠΈλ₯Ό 별도 span으둜 λΆ„λ¦¬ν–ˆμŠ΅λ‹ˆλ‹€. κ΄€λ ¨ λ‹€κ΅­μ–΄ λ§ˆν¬μ—… 지침도 λ¬Έμ„œμ— μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

Changes

μ™ΈλΆ€ 링크 μ‹œκ°μ  μ§€μ‹œμž

Layer / File(s) Summary
λ²ˆμ—­ λ§ˆν¬μ—… μ§€μΉ¨
.Jules/palette.md
μ™ΈλΆ€ λ§ν¬μ—μ„œ λ²ˆμ—­ λŒ€μƒ ν…μŠ€νŠΈμ™€ μ‹œκ°μ  μ§€μ‹œμžλ₯Ό 별도 μš”μ†Œλ‘œ λ°°μΉ˜ν•˜λŠ” 지침을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
μ™ΈλΆ€ 링크 λ§ˆν¬μ—… 적용
index.html
GitHub, μ°Έκ³ λ¬Έν—Œ, 곡개 ν”„λ‘œμ νŠΈ, Fork ν”„λ‘œμ νŠΈ, μ„€λ¦½μž 링크에 β†— ν‘œμ‹œλ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€. 곡개 ν”„λ‘œμ νŠΈμ™€ Fork 링크의 λ²ˆμ—­ ν‚€λ₯Ό 별도 span으둜 μ΄λ™ν–ˆμŠ΅λ‹ˆλ‹€.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed 제λͺ©μ€ μ™ΈλΆ€ 링크에 접근성을 κ³ λ €ν•œ μ‹œκ°μ  μ§€μ‹œμžλ₯Ό μΆ”κ°€ν•˜λŠ” μ£Όμš” λ³€κ²½ 사항을 μ •ν™•ν•˜κ²Œ μš”μ•½ν•©λ‹ˆλ‹€.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@opencode-agent

Copy link
Copy Markdown
Contributor

μžλ™ 정리: base λŒ€λΉ„ μ‹€μ œ λ³€κ²½(diff)이 0건이라 이 PR을 λ‹«μŠ΅λ‹ˆλ‹€. 변경을 μΆ”κ°€ν•œ λ’€ reopenν•˜μ„Έμš”.

@opencode-agent opencode-agent Bot closed this Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant