Skip to content

⚡ Bolt: [성능 개선] - #737

Open
seonghobae wants to merge 1 commit into
masterfrom
bolt-defer-string-allocation-6799197197944227033
Open

seonghobae wants to merge 1 commit into
masterfrom
bolt-defer-string-allocation-6799197197944227033

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

💡 내용: 디렉토리 순회 과정에서 사용되는 .toLowerCase() 문자열 할당 위치를 조건문 내로 지연시켜, 빠르고 비용이 저렴한 검사(isHiddenFile, endsWith)에서 조기 종료되도록 수정\n🎯 이유: 불필요한 문자열 객체 생성을 방지하여 가비지 컬렉션 부하를 줄이고 성능을 개선하기 위함\n📊 영향: 대규모 디렉토리 트리를 순회할 때 메모리 할당 및 가비지 컬렉션 호출 빈도 감소\n🔬 측정: 테스트 커버리지 유지 및 정적 분석 통과 확인


PR created automatically by Jules for task 6799197197944227033 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 23b4c891-efba-4bd2-ab6f-82a7825c90ad

📥 Commits

Reviewing files that changed from the base of the PR and between 728f0f3 and 0ee7c8a.

📒 Files selected for processing (2)
  • .jules/bolt.md
  • src/main/kotlin/html4tree/main.kt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae added enhancement New feature or request priority: medium Normal-priority or P2 work labels Sep 19, 2026 — with ChatGPT Codex Connector

@cwl-noema-review cwl-noema-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noema LLM review

The change reorders the sensitive-file exclusions so hidden files and tilde-suffixed files are handled before the lowercase name is computed, avoiding toLowerCase work when it is unnecessary. The new boolean logic is equivalent to the original: (hidden || tilde) || (sensitive-name || sensitive-extension) has the same exclusion result as the previous hidden || sensitive-name || tilde || sensitive-extension. The added .jules/bolt.md entry is documentation-only and does not affect behavior.

Reviewed changed lines

  • src/main/kotlin/html4tree/main.kt:354 (RIGHT): The early check on hidden/tilde files preserves the original exclusion behavior. it.endsWith("~") is equivalent to it.toLowerCase(...).endsWith("~") because the tilde character has no case conversion, so no file is accidentally included or excluded.
  • .jules/bolt.md:66 (RIGHT): Documentation-only change. It accurately describes the evaluation-order optimization in the function, and markdown additions cannot alter runtime behavior.

Adversarial validation

  • src/main/kotlin/html4tree/main.kt:354 (RIGHT) falsified: That the change drops the sensitive-name/extension check for non-hidden, non-tilde files. — The else block performs exactly the original normalizedName checks. The boolean becomes (hidden || tilde) || (sensitive-name || sensitive-extension), matching the original hidden || sensitive-name || tilde || sensitive-extension.
  • src/main/kotlin/html4tree/main.kt:357 (RIGHT) falsified: That moving toLowerCase into the else branch could change the sense of a hidden or tilde-only name that currently triggers exclusion. — For such files, original also entered files_to_exclude.add(it) because the hidden/tilde disjunct was true. No behavioral difference exists.
  • Residual risk: none

Findings

  • No blocking findings.
  • Result: APPROVE
  • Head SHA: 0ee7c8a2c01f1b623501633e10449d3e6a8019f3
  • Reviewer credential: noema-review-github-app-refresh
  • Actor: cwl-noema-review[bot]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: medium Normal-priority or P2 work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant