Repository navigation
CI: test branches through their pull request, not on every push too - #44
Merged
Merged
Conversation
tests.yml ran on push to every branch and on pull_request, so each push to a branch with an open pull request ran the whole matrix twice (the branch head and the merge commit). The two runs use different refs, so they could not cancel each other. - push runs on master only; a branch is tested through its pull request, or by hand with workflow_dispatch. - One run per pull request at a time: a newer push cancels the run of the commit it replaces. Runs on master are never cancelled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
jowr
added a commit
that referenced
this pull request
Nov 3, 2026
CHANGELOG: the examples join the Added list; the units entry was already under Changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013bsHH774XBx3sJCtfvvuGF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests.ymlran onpushto every branch and onpull_request. Every push to a branch with an open pull request therefore ran the whole matrix twice: once on the branch head (refs/heads/...) and once on the merge commit (refs/pull/N/merge). Because the two runs have different refs, a concurrency group could not reliably cancel one with the other.Change
pushruns onmasteronly. A branch is tested through its pull request, which tests the merge commit, the thing that actually gets merged.workflow_dispatchis added, so a branch without a pull request can still be run by hand (Actions tab, "Run workflow").concurrencygroup per pull request withcancel-in-progressfor pull request runs: a newer push cancels the run of the commit it replaces. Runs onmasterand the run thatrelease.ymlmakes throughworkflow_callare never cancelled.Trade-off
A pushed branch without a pull request gets no CI until a pull request is opened or the workflow is started by hand.
Testing
The workflow file parses (checked with PyYAML). This pull request's own CI is the real check: it should show one
testsrun per push, triggered bypull_request.Generated by Claude Code