Avoid generating empty thread_locals - #315
Open
FranciscoTGouveia wants to merge 2 commits into
Open
Conversation
Contributor
|
This patch seems weird. Isn't the code exactly the same before/after, just less efficient? |
Contributor
Author
|
Before, we would have: Whereas now, we just have: This has no performance implications, but it avoids generating meaningless statements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new
IsConvertableGlobalVarDeclfunction was introduced to determine whether the global variable declaration would emit any code.This was needed because empty thread locals were previously being generated (i.e.,
thread_local!()).