This repository was archived by the owner on Oct 16, 2026. It is now read-only.
Repository navigation
Conversation
Norbiros
force-pushed
the
docs/mention-migration-versioning-scheme
branch
from
November 28, 2025 15:54
4ea7844 to
a7c823d
Compare
Sanielia
reviewed
Nov 28, 2025
Norbiros
force-pushed
the
docs/mention-migration-versioning-scheme
branch
from
November 28, 2025 16:23
a7c823d to
dc6a14a
Compare
SzczurekYT
reviewed
Nov 29, 2025
SzczurekYT
left a comment
Contributor
There was a problem hiding this comment.
Two suggestions that can make this better imo, no other regards
|
|
||
| Each migration should be placed in a separate file inside the `src/config/migrations/` directory. File names must follow this pattern: | ||
| ```txt | ||
| m_<MAJOR>_<MINOR>_<PATCH>_<MIGRATION>_<VERY SHORT DESCRIPTION>.rs |
Contributor
There was a problem hiding this comment.
Suggested change
| m_<MAJOR>_<MINOR>_<PATCH>_<MIGRATION>_<VERY SHORT DESCRIPTION>.rs | |
| m_<MAJOR>_<MINOR>_<PATCH>_<MIGRATION>_<VERY_SHORT_DESCRIPTION>.rs |
| - **Node** - A node is a single value in the config tree. It can be a primitive type, a list, or a map. | ||
| - **Migration** - A migration is a function that takes a config and returns a new config. It is used to update the config to a new version. | ||
|
|
||
| ### Migration Version |
Contributor
There was a problem hiding this comment.
Suggested change
| ### Migration Version | |
| ### CrabCraft Migration Version |
Suggested change
| ### Migration Version | |
| ### Migration Version (CrabCraft) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.