Skip to content

fix: install private runtime across macOS and Linux - #1

Merged
Crokily merged 2 commits into
mainfrom
Fix/Crokily/cross-platform-runtime-install
Jul 16, 2026
Merged

Crokily merged 2 commits into
mainfrom
Fix/Crokily/cross-platform-runtime-install

Conversation

@Crokily

@Crokily Crokily commented Jul 16, 2026

Copy link
Copy Markdown
Owner

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b772037a27

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

*) fatal "unsupported architecture: $arch_raw (supported: x86_64, arm64/aarch64)" ;;
esac

lazygit_asset="lazygit_${LAZYGIT_VERSION}_${os}_${lazygit_arch}.tar.gz"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use LazyGit’s case-sensitive release OS names

os is normalized to lowercase here, but LazyGit v0.63.0 publishes its archives with Linux and Darwin in the filename (for example, lazygit_0.63.0_Linux_x86_64.tar.gz). GitHub release asset paths are case-sensitive, so the constructed LazyGit URL returns no asset on every supported platform and prevents plugin installation; the hermetic test masks this because its fake downloader accepts the lowercase names.

Useful? React with 👍 / 👎.

@Crokily
Crokily merged commit 0e79242 into main Jul 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant