Repository navigation
0.3.0: public-release hardening — LICENSE, AI disclosure, repo-identity launchers, per-pane layout, structured diff sampling - #3
Merged
Conversation
Owner
Author
|
Adversarial review round (Codex, xhigh) found 4 issues; all independently confirmed by the directing agent and fixed in a1b5062:
Regression tests added for all four in the existing suites. All suites green locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A public-release readiness audit (run with Codex) confirmed four gaps that mattered once the plugin went from personal use to public: no LICENSE, an inaccurate AI model/cost claim plus no data disclosure, launchers that could reuse a lazygit pane belonging to a different repository, and layout state that was global while being used as if per-pane. This PR fixes all four; implementation was done by Codex (gpt-5.4) under direction, each workstream independently verified before landing.
What (one commit per workstream)
AI_GEMINI_MODELpinned togemini-2.5-flash(flag verified againstgemini --help), settings pane covers it.foreground_cwdresolves to the SAME git worktree as the launch target (git rev-parse --show-toplevelboth sides; non-git dirs compare by path). Different repo / different worktree / any resolution failure → OPEN a new pane, never a wrong reuse. Newtests/launcher-decision-test.sh(fake herdr + real repos/worktrees).LAYOUT_MODEleaves the sharedpanel.conf; each pane owns alayout-<pid>-<epoch>.ymllayer (between generated.yml and lazygit-user.yml),Umutates only its own file, stale layers are cleaned by PID liveness on startup. panel.conf keeps only global prefs. Newtests/layout-state-isolation-test.sh.tests/ai-diff-sampling-test.shand aHERDR_LAZYGIT_TEST_PRINT_AI_INPUT=1hook.Verification (by the directing agent, independently of Codex's own runs)
sampled 2/3 files, 2/3 hunks. Under the old code this payload was 8,000 chars of lockfile noise.git worktree.Deferred by owner decision: the git-index race during AI generation (low probability; cheap
git write-treemitigation documented in the audit if ever needed).