Repository navigation
Wait for keyboard actions before switching tabs in smoke tests - #7
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2fdc784394
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Rendering can precede the launcher's final tab.focus RPC. | ||
| # Wait for that action to finish before the test changes tabs, | ||
| # or its late focus can undo our next source-tab selection. | ||
| wait_for(completed_action, 'keybinding action completion') |
There was a problem hiding this comment.
When an open-tab action takes between 8 and 10 seconds on a slow CI runner, this wait reports a failure even though the action is still within launcher.py's TOTAL_TIMEOUT = 10.0 and may complete successfully. Since this synchronization was added specifically to handle delayed action completion, use a timeout longer than the launcher's full deadline (plus log propagation margin) rather than the shared eight-second wait_for limit.
Useful? React with 👍 / 👎.
The post-merge Ubuntu/Herdr 0.7.5 smoke test could return to the source tab while the preceding keyboard action was still running. Its final focus request then selected Git again, causing the source-view assertion to time out.
Wait for the newly triggered
open-tabaction log to report success before changing tabs. Failed actions still fail the test, and the actual client rendering assertions remain in place. Plugin runtime behavior is unchanged.Validation: local real-client smoke tests passed with Herdr 0.7.5 and 0.9.0. The validation record and changelog describe the race. Follow-up to #6.