Repository navigation
Fix concurrency test expectations under lock contention - #9
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.4.0 main CI failed on macOS because a concurrency test shortened the launcher lock deadline to 0.3 seconds while requiring both actions to succeed. A correctly reported busy lock was treated as a failure; an early assertion also left another test child and its pipes unreaped.
Deliberately delay focus by 0.5 seconds, accept only the specific bounded busy-lock response, and retry after both jobs finish. Require two successful focus operations overall, no pane creation/closure, a shared lock file and no inherited lock descriptors. Register child cleanup and collect all concurrent results before asserting.
Validation: the old test reproduces the CI failure with the injected delay; all 18 updated launcher tests pass with ResourceWarnings promoted to errors. Runtime behavior, deadlines and the published v0.4.0 tag are unchanged. Changelog and validation notes updated.