fix(push): resolve enable-button hang, move card to profile page - #443
Merged
Merged
Conversation
CropWatchDevelopment
commented
Aug 25, 2026
CropWatchDevelopment
commented
Owner
- enablePush hung forever awaiting navigator.serviceWorker.ready, which only settles when a worker controls the page; the push worker's /push-sw/ scope controls none. Wait for the registration's own worker to activate instead.
- notificationclick: client.navigate() rejects for uncontrolled pages, so focus a tab only when it already shows the target URL, else openWindow.
- Move PushNotificationsCard from /settings to /account/profile beneath the LINE card.
- enablePush hung forever awaiting navigator.serviceWorker.ready, which only settles when a worker controls the page; the push worker's /push-sw/ scope controls none. Wait for the registration's own worker to activate instead. - notificationclick: client.navigate() rejects for uncontrolled pages, so focus a tab only when it already shows the target URL, else openWindow. - Move PushNotificationsCard from /settings to /account/profile beneath the LINE card. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.