fix(rules): stop wiping live rule state on template update - #81
Merged
Merged
Conversation
PATCH /v1/rules/:id blanket-deleted cw_rule_state for the whole template, erasing is_triggered mid-alert — the alert service could then never run its reset path, orphaning cw_rule_trigger_log rows that render as still-active alerts forever. - update() now deletes state only for devices removed from the template and administratively closes their open trigger-log rows (reset_at = now(), reset_value null); state for still-assigned devices survives edits. - remove() also closes all open trigger-log rows before deleting the template so history rows cannot be orphaned open. - New spec coverage for update/remove via a per-table client stub router. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
CropWatchDevelopment
temporarily deployed
to
Production
July 29, 2026 07:53 — with
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PATCH /v1/rules/:id blanket-deleted cw_rule_state for the whole template, erasing is_triggered mid-alert — the alert service could then never run its reset path, orphaning cw_rule_trigger_log rows that render as still-active alerts forever.