Repository navigation
ci: new release flow by handle publish package after create-rele - #137
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Symbol publishing and retry behavior can leave releases incomplete.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Restructures the release workflow so package publication follows validation, builds, and release creation.
Changes:
- Adds release validation and serialized execution.
- Builds packages from the version-update commit.
- Defers Rust and NuGet publication until after release creation.
| File | Description |
|---|---|
.github/workflows/build-release.yaml |
Reorganizes validation, building, release, publishing, and cleanup jobs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, NuGet packages could be published before release tag validation and GitHub release creation had completed.
This change ensures that
dotnet nuget pushruns only after the tag has been validated andcreate-releasehas succeeded.