Conversation
CLAP 1.2 only allows clap_host_latency.changed() during activate(). Request a restart when the latency changes while active and report the new value on the next activate().
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLAP 1.2 only allows
clap_host_latency.changed()while the plugin is being activated. DPF still calls it outsideactivate(), so clap-validator 0.4.1 fails 22 tests on any plugin with a non-zero latency.With this change, a latency change while active requests a restart and the new value is reported from
activate(); a change while inactive is reported on the nextactivate().This also covers #541. It overlaps #544, which fixes the initial report on activation; this one also handles a latency that changes with a parameter while the plugin is running.
Tested with clap-validator 0.4.1 on a plugin whose latency depends on a parameter: 22 failures before, none after.